Tyf0x
commented
7 years ago Maybe using something like: https://github.com/atom/find-and-replace/pull/547/commits/17829ba6dd8e3033989899c2449636948e63c929
Catching this kind of error and avoiding the big ugly uncaught exception would be neat. Would an extra no-intrusive message to explain why the highlight didn't work be a good idea too?
[Enter steps to reproduce below:]
Atom Version: 1.11.2 Electron Version: 0.37.8 System: Microsoft Windows 10 Pro Thrown From: highlight-selected package, v0.11.2
Stack Trace
Uncaught SyntaxError: Invalid regular expression: /\bdata:image\/gif;base64,R0lGODlhyADIAPIGAP\/\/\/xkZGf\/U1P\/m5nlgYP7AwAAAAAAAACH\/C05FVFNDQVBFMi4wAwEAAAAh\/gNHNDQAIf [...snip...] BTF+FL1wXQkvkAAAOw\b/: RegExp too big at RegExp.exec (native) at Forwards.next (C:\Users\myuser\AppData\Local\atom\app-1.11.2\resources\app.asar\node_modules\text-buffer\lib\match-iterator.js:15:30) at TextBuffer.module.exports.TextBuffer.scanInRange (C:\Users\myuser\AppData\Local\atom\app-1.11.2\resources\app.asar\node_modules\text-buffer\lib\text-buffer.js:984:31) at TextEditor.module.exports.TextEditor.scanInBufferRange (C:\Users\myuser\AppData\Local\atom\app-1.11.2\resources\app.asar\src\text-editor.js:2602:26) at HighlightedAreaView.module.exports.HighlightedAreaView.handleSelection (file:///C:/Users/myuser/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:114:12) at HighlightedAreaView.handleSelection (file:///C:/Users/myuser/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:1:1) at file:///C:/Users/myuser/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:48:8
2x -4:08.8.0 core:undo (atom-text-editor.editor.is-focused) -4:07.8.0 core:save (atom-text-editor.editor.is-focused) -3:56.7.0 core:backspace (atom-text-editor.editor.is-focused) -3:56.3.0 editor:move-to-first-character-of-line (atom-text-editor.editor.is-focused) 2x -3:54.8.0 core:save (atom-text-editor.editor.is-focused) -2:33.8.0 settings-view:open (atom-text-editor.editor.is-focused) -2:21.2.0 core:delete (atom-text-editor.editor.is-focused) -0:13.2.0 editor:select-to-end-of-line (atom-text-editor.editor.is-focused) -0:12.6.0 editor:select-to-beginning-of-word (atom-text-editor.editor.is-focused) -0:04.8.0 editor:select-to-end-of-line (atom-text-editor.editor.is-focused) 4x -0:04.1.0 editor:select-to-beginning-of-word (atom-text-editor.editor.is-focused)
Installed Packages