search

Pulsar-Edit-Highlights / selected

@Pulsar-Edit package for highlighting occurrences of your selection.
https://web.pulsar-edit.dev/packages/highlight-selected
MIT License
248 stars 67 forks source link

Uncaught TypeError: editor.addMarkerLayer is not a function #165

Open Overload119 opened 6 years ago

Overload119 commented 6 years ago

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.24.0 x64 Electron: 1.6.16 OS: Mac OS X 10.13.3 Thrown From: highlight-selected package 0.13.1

Stack Trace

Uncaught TypeError: editor.addMarkerLayer is not a function

At /Users/asharifr/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:143

TypeError: editor.addMarkerLayer is not a function
    at HighlightedAreaView.module.exports.HighlightedAreaView.highlightSelectionInEditor (/packages/highlight-selected/lib/highlighted-area-view.coffee:143:27)
    at /packages/highlight-selected/lib/highlighted-area-view.coffee:136:10
    at Array.forEach (native)
    at HighlightedAreaView.module.exports.HighlightedAreaView.handleSelection (/packages/highlight-selected/lib/highlighted-area-view.coffee:135:27)
    at HighlightedAreaView.handleSelection (/packages/highlight-selected/lib/highlighted-area-view.coffee:1:1)
    at /packages/highlight-selected/lib/highlighted-area-view.coffee:62:8

Commands

     -0:10.6.0 editor:select-to-beginning-of-word (input.hidden-input)
     -0:10.5.0 editor:select-to-end-of-word (input.hidden-input)
     -0:10.4.0 editor:select-to-beginning-of-word (input.hidden-input)
     -0:10.3.0 editor:select-to-end-of-word (input.hidden-input)
     -0:10.2.0 editor:select-to-beginning-of-word (input.hidden-input)
     -0:10.1.0 editor:select-to-end-of-word (input.hidden-input)
     -0:09.8.0 editor:select-to-beginning-of-word (input.hidden-input)
     -0:09.5.0 datatip:toggle (input.hidden-input)
     -0:04.4.0 editor:move-to-first-character-of-line (input.hidden-input)
     -0:04.4.0 editor:move-to-end-of-screen-line (input.hidden-input)
     -0:04.3.0 editor:move-to-first-character-of-line (input.hidden-input)
     -0:04.2.0 editor:move-to-end-of-screen-line (input.hidden-input)
     -0:03.8.0 datatip:toggle (input.hidden-input)
  2x -0:03.8.0 editor:move-to-beginning-of-word (input.hidden-input)
     -0:02.6.0 editor:select-to-end-of-word (input.hidden-input)
     -0:02.1.0 datatip:toggle (input.hidden-input)

Non-Core Packages

color-picker 2.2.5 
copy-filename 1.1.0 
cursor-history 0.13.1 
expand-selection-to-indentation 0.4.0 
file-icons 2.1.17 
highlight-selected 0.13.1 
indent-sort 0.5.0 
language-babel 2.84.0 
language-graphql 0.9.0 
language-haskell 1.17.3 
language-ini 1.19.0 
language-lua 0.9.11 
language-ocaml 1.9.5 
language-rust 0.4.12 
language-scala 1.1.9 
language-swift 0.5.0 
language-thrift 1.0.2 
MagicPython 1.0.12 
nuclide 0.287.95784552 
nuclide-format-js 0.0.44 
recent-files-fuzzy-finder 0.4.0 
set-syntax 0.4.0 
sort-lines 0.18.0 
tool-bar 1.1.6
el1t commented 6 years ago

Still happens on atom 1.27.1, package version 0.13.1. Seems like an issue with highlighting in read-only panes. To reproduce:

  1. Enable "Highlight In Panes"
  2. Open a normal pane
  3. Open a read-only pane
  4. Highlight in the normal pane