PulseTile / PulseTile-Docs

Documentation for PulseTile
http://docs.pulsetile.com/
2 stars 5 forks source link

Chart display at the bottom of the documentation is broken #16

Open pacharanero opened 7 years ago

pacharanero commented 7 years ago

On first loading the page, the 'Chart Bar' section displays a Line chart:

2017 11 14-16 12 41-selection

However once a mouseOver event has occurred over this chart, it changes to a Bar chart and will not change back.

2017 11 14-16 12 13-selection

All the time, the 'Chart Line' section remains greyed out


Platform: Linux-4.11.0-14-generic-x86_64-with-LinuxMint-18.2-sonya Browser: Google Chrome 62.0.3202.94 Date Tested :Tue 14 Nov 16:38:04 GMT 2017

tony-shannon commented 7 years ago

thanks Marcus Which page is involved please? thanks Tony

On 14 November 2017 at 16:38, Marcus Baw notifications@github.com wrote:

On first loading the page, the 'Chart Bar' section displays a Line chart:

[image: 2017 11 14-16 12 41-selection] https://user-images.githubusercontent.com/2348385/32790662-f355d4f6-c956-11e7-9c65-62abfe930b82.png

However once a mouseOver event has occurred over this chart, it changes to a Bar chart and will not change back.

[image: 2017 11 14-16 12 13-selection] https://user-images.githubusercontent.com/2348385/32790701-0eba2f6c-c957-11e7-8ceb-4beccbe17675.png

All the time, the 'Chart Line' section remains greyed out

Platform: Linux-4.11.0-14-generic-x86_64-with-LinuxMint-18.2-sonya Browser: Google Chrome 62.0.3202.94 Date Tested :Tue 14 Nov 16:38:04 GMT 2017

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PulseTile/PulseTile-Docs/issues/16, or mute the thread https://github.com/notifications/unsubscribe-auth/AA5X3GWgatsF3JYufyc8ABue5ciE_-Ykks5s2cIBgaJpZM4QdobA .

pacharanero commented 7 years ago

sorry, I should have put that in the initial issue report

It's http://showcase2.ripple.foundation/ui-kit.html#/charts I'm just looking over the source locally now to find where this originates from

pacharanero commented 7 years ago

​​It's http://showcase2.ripple.foundation/ui-kit.html#/charts

I've tried to find the source code for this section but it seems to be at a different site to the rest of the documentation and not part of the same Jekyll site?

Marcus

On 14 November 2017 at 17:37, Tony Shannon notifications@github.com wrote:

thanks Marcus Which page is involved please? thanks Tony

On 14 November 2017 at 16:38, Marcus Baw notifications@github.com wrote:

On first loading the page, the 'Chart Bar' section displays a Line chart:

[image: 2017 11 14-16 12 41-selection] https://user-images.githubusercontent.com/2348385/ 32790662-f355d4f6-c956-11e7-9c65-62abfe930b82.png

However once a mouseOver event has occurred over this chart, it changes to a Bar chart and will not change back.

[image: 2017 11 14-16 12 13-selection] https://user-images.githubusercontent.com/2348385/ 32790701-0eba2f6c-c957-11e7-8ceb-4beccbe17675.png

All the time, the 'Chart Line' section remains greyed out

Platform: Linux-4.11.0-14-generic-x86_64-with-LinuxMint-18.2-sonya Browser: Google Chrome 62.0.3202.94 Date Tested :Tue 14 Nov 16:38:04 GMT 2017

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PulseTile/PulseTile-Docs/issues/16, or mute the thread https://github.com/notifications/unsubscribe-auth/ AA5X3GWgatsF3JYufyc8ABue5ciE_-Ykks5s2cIBgaJpZM4QdobA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PulseTile/PulseTile-Docs/issues/16#issuecomment-344337071, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVYb8kw6OFGTtUWNFlCrh1et-QjPobks5s2c_JgaJpZM4QdobA .

tony-shannon commented 7 years ago

OK so this it what we call UI-Kit related Correct, this proved v difficult to do from within the Jekyll documentation theme, so it comes directly from the PulseTile codebase See here https://github.com/PulseTile/PulseTile/blob/develop/src/app/pulsetileui/pages/ui-kit/ui-kit.component.js Can u see the issue there? Note the branch issue below, but feel free to suggest a fix ..

@kbeloborodko FYI.. NB I see 3 branches with UI-kit, develop looks most up to date, can you confirm that http://docs.pulsetile.com/ui_kit_page.html is up to date with latest branch?

thanks T

pacharanero commented 7 years ago

I'll have a look and see if I can spot the issue M

On 14 November 2017 at 20:42, Tony Shannon notifications@github.com wrote:

OK so this it what we call UI-Kit related Correct, this proved v difficult to do from within the Jekyll documentation theme, so it comes directly from the PulseTile codebase See here https://github.com/PulseTile/PulseTile/blob/67adf894fd75da5be87b6a49ee0d43 f5f6b9485b/src/app/pulsetileui/pages/ui-kit/ui-kit.component.js Can u see the issue there? Feel free to suggest a fix thanks T

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PulseTile/PulseTile-Docs/issues/16#issuecomment-344391632, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVYZNH6sf-TroQXfyFDNr2lxYP4Tbjks5s2fsagaJpZM4QdobA .

tony-shannon commented 7 years ago

thanks Marcus T

On 15 November 2017 at 09:48, Marcus Baw notifications@github.com wrote:

I'll have a look and see if I can spot the issue M

On 14 November 2017 at 20:42, Tony Shannon notifications@github.com wrote:

OK so this it what we call UI-Kit related Correct, this proved v difficult to do from within the Jekyll documentation theme, so it comes directly from the PulseTile codebase See here https://github.com/PulseTile/PulseTile/blob/ 67adf894fd75da5be87b6a49ee0d43 f5f6b9485b/src/app/pulsetileui/pages/ui-kit/ui-kit.component.js Can u see the issue there? Feel free to suggest a fix thanks T

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PulseTile/PulseTile-Docs/issues/16# issuecomment-344391632, or mute the thread https://github.com/notifications/unsubscribe-auth/ACPVYZNH6sf- TroQXfyFDNr2lxYP4Tbjks5s2fsagaJpZM4QdobA .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PulseTile/PulseTile-Docs/issues/16#issuecomment-344540490, or mute the thread https://github.com/notifications/unsubscribe-auth/AA5X3BYfpRZhkK80sXe8Ief0Z4M-7d9Vks5s2rNjgaJpZM4QdobA .