PulseTile RA - troubleshooting build files - dependency versions +/- minification

[tony-shannon]

as result of discussion on UI bugs noted here https://github.com/RippleOSI/NHS_Ed_Scotland_Open_Platform/issues/53

we need to investigate the root cause of some of this bizarre behaviour at the UI

Few points; Local dev seems ok according to Bogdan Remote deployment is where we are seeing the issue, on DO VPS machine So likely to be an issue with the build/minification process

Few points to note

• Dependencies/versions

React Admin currently uses version 1.5.1 of Material UI, not the latest version 3.8.9, so that needs checking for consistency .. can be checked in node-modules directory

Other dependencies eg here need to be updated; https://github.com/PulseTile/PulseTile-RA/blob/scotland/package.json eg https://github.com/PulseTile/PulseTile-RA/blob/scotland/package.json#L32 "react-scripts": "1.1.4",

As the build process involves Create React App, which involves react-scripts this is now of of date (latest version of react-scripts is 2.1.8) . Important to note that use of ^ would help ensure latest version is involved https://michaelsoolee.com/npm-package-tilde-caret/ So recommend to use "react-scripts": "^1.1.4" or perhaps ,"react-scripts": "^2.1.8"

Also note that the versions here are out of sync and out of date; https://github.com/PulseTile/PulseTile-RA/blob/scotland/package.json#L22 https://github.com/PulseTile/PulseTile-RA/blob/scotland/package.json#L24 suggest both are reconciled to the same version "^2.7.3"

If these are updated, it should help a lot

Then

• Development to Deploy Locally One way to investigate these issues is suggest that devs deploy their build file in local web server eg nginx to see if any issues are found that would make debugging easier

• +/- Disabling Minification If issues still evident then consider disabling minifiication of the build; in Create React App with yarn/npm.. we would need more info on this If would increase size of build file , but a good webserver like nginx used gzip anyway, so may not be such a problem The minification step could be where problems are introduced between dev & deployment The way to analyse those would be to find one bug, id where the minified code is problematic and trace back to the original source code to see where the minification error arises

[BogdanScherban]

This issue was solved by dependencies updates.