Convert all models to exponential

PumasAI-Labs / Bayesian-Benchmarks

Code for the Pumas Bayesian Benchmarks Paper

0 stars 0 forks source link

Convert all models to exponential #93

Closed storopoli closed 1 year ago

storopoli commented 1 year ago

[x] Pumas
[x] NONMEM (yes, but missing 04-mm, Cc @PavanVaddady)

We still need to fix the JSON inits in NONMEM

cbdavis33 commented 1 year ago

01-iv_2cmt_linear/Pumas/iv_2cmt.jl has the model named "iv_2cmt_prop". The model is right - we've got dv ~ LogNormal(log(cp, \sigma)), and it calls the correct function, but just for consistency and correctness, can you change the model name to "iv_2cmt_exp"

storopoli commented 1 year ago

01-iv_2cmt_linear/Pumas/iv_2cmt.jl has the model named "iv_2cmt_prop". The model is right - we've got dv ~ LogNormal(log(cp, \sigma)), and it calls the correct function, but just for consistency and correctness, can you change the model name to "iv_2cmt_exp"

Done