search

PumasAI / QuartoNotebookRunner.jl

MIT License
63 stars 10 forks source link

Use quarto-provided markdown if present #154

Closed jkrumbiegel closed 5 months ago

jkrumbiegel commented 5 months ago

Fixes https://github.com/quarto-dev/quarto-cli/issues/10008 as options.target.markdown.value contains the markdown after quarto has applied shortcode expansions to it. If we receive this, we prefer it over the contents of the original source file. I tried this with a simple example:

main.qmd

---
engine: julia
---

{{< include to_include.qmd >}}

```{julia}
x

to_include.qmd
x = 1


Which resulted in:

<img width="410" alt="image" src="https://github.com/PumasAI/QuartoNotebookRunner.jl/assets/22495855/d1acc48b-18e6-4672-9c83-401c2be50829">
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review. Files Patch % Lines
src/server.jl 93.93% 2 Missing :warning:
src/socket.jl 80.00% 2 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!

jkrumbiegel commented 5 months ago

@MichaelHatherly any more thoughts about the quarto integration test? Otherwise we can merge this