search

PunchRVA / starterfiles

A set of starter files for web projects. A never-ending work in progress.
1 stars 0 forks source link

Default font definition fails in IE9 #10

Closed Chris-May closed 8 years ago

Chris-May commented 9 years ago

From starterfiles/htdocs/assets/scss/global-partials/_typography.scss:4: Using rem-calc() to define default font makes this un-usable for IE9.

Maybe(?) we should have a fallback commented out for when we need to support IE9?

OR

Is a rem needed at this point, since it's applying to <body>... possibly since I think font is being inherited through the cascade?

philbarbato commented 8 years ago

We should be able to use em on the body element.

philbarbato commented 8 years ago

So, the $body-font-size and $body-line-height variables are not just used on the body element. They're used to maintain a standard size we can use directly or multiplied/divided in some way. I use $body-line-height to set vertical margins and padding and even heights of some items as well. This is my ongoing effort to maintain some kind of vertical rhythm.

By keeping the variable in rems, we can change font sizes globally and maintain the relative sizes of everything without worrying about em cascade.

I think a REM polyfill wrapped in an IE conditional is what's called-for here.