search

PundiAI / fx-core

https://functionx.gitbook.io
Apache License 2.0
21 stars 14 forks source link

refactor(x/crosschain): move base to bridgeToken to AddToOutgoingPool #716

Closed zakir-code closed 2 weeks ago

zakir-code commented 2 weeks ago

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The pull request introduces significant modifications across several test files and the implementation of the MsgServer and Keeper structs. Key changes include the simplification of token handling logic, particularly for bridge tokens, by replacing existing methods with new ones that streamline the creation and minting processes. Additionally, the test suites have been restructured to enhance clarity and maintainability, with some tests being temporarily disabled. Overall, the changes focus on improving the handling of tokens, particularly in cross-chain scenarios, and refining the associated test cases.

Changes

File Path Change Summary
x/crosschain/keeper/genesis_test.go Modified TestBatchAndTxImportExport to replace GenHexAddress() with AddRandomBaseToken(), simplifying minting logic.
x/crosschain/keeper/grpc_query_v1_test.go Restructured CrossChainGrpcTestSuite to inherit from KeeperTestSuite. Commented out TestCrossChainGrpcTestSuite_bsc. Updated TestCrossChainGrpcTestSuite_eth.
x/crosschain/keeper/keeper_v1_test.go Added AddRandomBaseToken and MintBaseToken methods to KeeperTestSuite.
x/crosschain/keeper/msg_server.go Removed fxtypes import; simplified SendToExternal method by eliminating denomination conversion logic.
x/crosschain/keeper/msg_server_test.go Restructured tests for message types, enhanced error handling, and added new test cases.
x/crosschain/keeper/outgoing_pool.go Replaced GetContractByBridgeDenom with BaseCoinToBridgeToken. Rewrote handleCancelRefund for simplicity.
x/crosschain/keeper/outgoing_pool_test.go Updated TestKeeper_OutgoingPool to simplify logic and focus on base tokens.
x/crosschain/precompile/cancel_send_to_external_test.go Added suite.T().SkipNow() to TestCancelSendToExternal and TestDeleteOutgoingTransferRelation.
x/crosschain/precompile/crosschain_test.go Added SkipNow() to TestCrossChain and structured various cross-chain tests.
x/crosschain/precompile/increase_bridgefee_test.go Added SkipNow() to TestIncreaseBridgeFee.
x/crosschain/precompile/keeper.go Removed denomination conversion logic from handlerCrossChain.
x/tron/keeper/grpc_query_test.go Removed TestKeeper_BatchFees function and its associated test cases.

Possibly related PRs

🐇 In the meadow, tokens play,
With bridges built, they find their way.
No more fuss, just mint and send,
A simpler path, around the bend.
Tests may skip, but soon they'll run,
For every change, there's joy and fun! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.