search

PundiAI / fx-core

https://functionx.gitbook.io
Apache License 2.0
21 stars 14 forks source link

refactor: convert token in bridgecall #724

Closed zakir-code closed 1 week ago

zakir-code commented 1 week ago

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 1 week ago

Walkthrough

The pull request introduces significant modifications across multiple files, primarily enhancing the FxTarget struct and its methods, as well as refactoring the token handling logic in the keeper package. Key changes include the addition of a variadic parameter for hex decoding in the ParseFxTarget function, the introduction of new methods for converting addresses, and a shift from ERC20 token handling to base coin handling in bridge call processes. Several methods have been updated or removed to streamline functionality and improve clarity in token conversions and bridge call management.

Changes

File Change Summary
types/target.go Updated ParseFxTarget to accept a variadic boolean parameter isHex. Added method ReceiveAddrToStr to convert sdk.AccAddress to string based on Prefix. Updated import statements.
x/crosschain/keeper/bridge_call_in.go Refactored BridgeCallHandler to use IsMemoSendCallTo(). Renamed receiverTokenAddr to receiverAddr. Shifted from types.NewERC20Tokens to base coins handling. Updated method signatures for BridgeCallFailedRefund and BridgeCallEvm.
x/crosschain/keeper/bridge_call_out.go Updated AddOutgoingBridgeCall method to replace tokens with baseCoins. Created new tokens slice from baseCoins.
x/crosschain/keeper/hook.go Removed PrecompileBridgeCall method from Keeper struct.
x/crosschain/keeper/many_to_one.go Renamed BridgeTokenToBaseCoin to EvmToBaseCoin. Added BaseCoinToEvm. Updated method signatures for token conversion.
x/crosschain/keeper/send_to_fx.go Modified SendToFxExecuted to use claim.Amount directly. Updated RelayTransferHandler to parse fxTarget directly from claim.TargetIbc. Changed logic for ibcReceiveAddress.
x/crosschain/mock/expected_keepers_mocks.go Added ConvertERC20 method to MockErc20Keeper.
x/crosschain/precompile/bridge_call.go Renamed variables and modified token handling logic. Updated method to invoke bridge calls.
x/crosschain/types/expected_keepers.go Added ConvertERC20 method to Erc20Keeper interface. Moved GetTokenPair method.
x/crosschain/types/types.go Removed NewERC20Tokens function. Other methods remain unchanged.

Possibly related PRs

🐰 In the meadow, changes abound,
With tokens and bridges, new paths are found.
Hex strings decoded, addresses in sight,
Simplified logic, everything feels right.
Hopping along, we embrace the new day,
For every small change, we cheer and we play! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.