perf(crosschain): simplify code and module references

[zakir-code]

Summary by CodeRabbit

• New Features

  • Introduced a new method in the Erc20Keeper interface for setting outgoing transfer relations.
  • Added methods in the CrosschainKeeper interface for converting base coins to IBC coins and adding transactions to the outgoing pool.

• Bug Fixes

  • Enhanced address validation during transfer operations to prevent invalid addresses.

• Refactor

  • Streamlined cross-chain functionality by removing direct calls to the crossChainKeeper, utilizing a router for access instead.
  • Removed unnecessary parameters from several function signatures to simplify instantiation processes.

• Chores

  • Deleted the hook.go file that previously handled post-transfer operations.

[coderabbitai[bot]]

Walkthrough

The pull request introduces significant changes to the cross-chain functionality within the application. Key modifications include the removal of the appKeepers.EthKeeper parameter from the NewAppKeeper function and the deletion of the TransferAfter method in the hook.go file. Additionally, the NewPrecompiledContract function no longer accepts the crossChainKeeper parameter, and several updates were made to the Erc20Keeper and CrosschainKeeper interfaces. These changes streamline the instantiation of components and enhance the handling of transfers and validations related to cross-chain operations.

Changes

File Path	Change Summary
app/keepers/keepers.go	Removed appKeepers.EthKeeper from NewAppKeeper instantiation of crosschainprecompile.NewPrecompiledContract.
x/crosschain/keeper/hook.go	Deleted hook.go which contained the TransferAfter method.
x/crosschain/precompile/contract.go	Removed crossChainKeeper parameter from NewPrecompiledContract function signature.
x/crosschain/precompile/expected_keepers.go	- Added SetOutgoingTransferRelation to Erc20Keeper. - Removed TransferAfter from CrosschainKeeper. - Added BaseCoinToIBCCoin and AddToOutgoingPool to CrosschainKeeper.
x/crosschain/precompile/keeper.go	Removed crossChainKeeper field from Keeper struct; updated methods to access cross-chain functionality via router.

Possibly related PRs

• #468: The changes in this PR involve the removal of the EvmKeeper parameter from the NewPrecompiledContract function, which is similar to the removal of appKeepers.EthKeeper in the main PR's NewAppKeeper function, indicating a restructuring of dependencies related to cross-chain functionality.
• #716: This PR focuses on moving the logic for handling bridge tokens to the AddToOutgoingPool method, which aligns with the main PR's changes that streamline cross-chain operations by modifying how components are instantiated and interact.
• #723: The modifications in this PR refine the conversion logic between IBC coins and base coins during transfers, which relates to the main PR's focus on restructuring cross-chain functionalities and removing certain parameters that affect how these conversions are handled.

🐇 In the land of code, changes unfold,
A keeper's tale, in whispers told.
With hooks removed and paths anew,
Cross-chain dreams are coming true.
So hop along, let's take a glance,
At how we dance in this code romance! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.