Closed zakir-code closed 1 week ago
The pull request introduces several enhancements to the testing and governance functionalities within the application. Key modifications include the addition of new functions for checking governance parameters and simplifying key deletion logic in the upgrade tests. Additionally, new functions are implemented in the upgrade handler to manage governance parameters during upgrades, while deprecated key management is introduced in the migrations. The changes also involve the removal of outdated variables from the governance types.
File | Change Summary |
---|---|
app/upgrade_test.go | - Added imports for distributiontypes , govtypes , fxgovv8 , and fxgovtypes . - Added checkGovCustomParams function. - Updated checkStakingMigrationDelete to call checkKeysIsDelete . - Added checkKeysIsDelete function. |
app/upgrades/v8/upgrade.go | - Added imports for storetypes and govtypes . - Updated CreateUpgradeHandler to call migrationGovCustomParam . - Added migrationGovCustomParam function. |
x/gov/migrations/v8/migrate.go | - Introduced migrate.go with deprecated key prefixes. - Added GetRemovedStoreKeys and DeleteOldParamsStore functions. |
x/gov/types/params.go | - Removed FxBaseParamsKeyPrefix and FxEGFParamsKey variables. |
x/staking/migrations/v8/migrate.go | - Renamed GetRemovedValidatorStoreKeys to GetRemovedStoreKeys . - Marked ValidatorOperatorKey , ConsensusPubKey , and ConsensusProcessKey as deprecated. |
🐇 In the code we hop and play,
With governance in a bright new way.
Old keys are gone, new checks in place,
Upgrades now run with a joyful grace.
Testing's strong, our path is clear,
Hopping forward, we have no fear! 🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores