PundiAI / fx-core

https://functionx.gitbook.io
Apache License 2.0
21 stars 14 forks source link

refactor: many-to-one logic #746

Closed zakir-code closed 5 days ago

zakir-code commented 5 days ago

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 5 days ago

Walkthrough

This pull request encompasses a series of changes across multiple files, focusing primarily on the ERC20 token handling within the application. Key modifications include the replacement of the TokenPair type with ERC20Token, adjustments to various structures and methods, simplification of configuration parameters, and the introduction of new message types. Additionally, several files related to deprecated functionalities have been removed, and the Makefile has been updated to reflect changes in linting rules. Overall, the changes aim to streamline the ERC20 module and improve its integration within the broader application framework.

Changes

File Path Change Summary
Makefile Updated check-no-lint target to reduce allowed nolint comments from 29 to 26.
api/fx/erc20/v1/genesis.pulsar.go Replaced TokenPair with ERC20Token, updated GenesisState and Params structs, removing certain fields.
api/fx/erc20/v1/types.pulsar.go Introduced new message types: ERC20Token, BridgeToken, IBCToken, and an enum Owner.
app/app_test.go Added new message types to the deprecated map in Test_MsgServiceRouter.
app/encoding_test.go Adjusted assertion in TestRegisterInterfaces from 298 to 293.
app/genesis.go Updated NewDefAppGenesisByDenom function for DenomMetadata population.
app/genesis.json Removed enable_evm_hook and ibc_timeout parameters from erc20 section.
app/interface_registry.json Removed several entries related to fx.erc20 module from TypeURLMap.
app/keepers/keepers.go Refactored NewAppKeeper function and updated initialization of keeper instances.
docs/swagger-ui/swagger.yaml Removed several API endpoints and restructured response schemas for ERC20-related queries.
go.mod Updated dependencies, reintroducing golang.org/x/exp and replacing some dependencies with forked versions.
proto/fx/erc20/v1/erc20.proto Deleted file defining Protocol Buffers schema for ERC20 functionality.
proto/fx/erc20/v1/genesis.proto Updated import statement and changed GenesisState message to use ERC20Token.
proto/fx/erc20/v1/legacy.proto Introduced new message definitions for ERC20 conversions, marked as deprecated.
proto/fx/erc20/v1/query.proto Updated import statement, marked several RPC methods as deprecated, and changed return types.
proto/fx/erc20/v1/types.proto Introduced new Protocol Buffers file defining message types related to ERC20 tokens.
tests/crosschain_suite.go Removed SelectTokenMetadata method.
tests/crosschain_test.go Overhauled CrossChainTest function for structured testing of cross-chain interactions.
tests/erc20_suite.go Removed several methods related to ERC20 token handling.
x/crosschain/keeper/bridge_call_in.go Renamed variables for clarity and altered logic for handling bridge tokens.
x/crosschain/keeper/bridge_call_out.go Updated handling of outgoing bridge calls with new parameters.
x/erc20/keeper/keeper.go Significant restructuring of Keeper struct, including new fields and methods related to ERC20 token management.
x/erc20/keeper/msg_server.go Transitioned from Keeper method receiver to a new msgServer type, altering method signatures and logic.
x/erc20/module.go Removed command methods from AppModuleBasic, updated service registration, and added error handling in InitGenesis and ExportGenesis.
x/erc20/types/errors.go Updated error messages for ErrUndefinedOwner and ErrERC20TokenPairDisabled.
x/erc20/types/events.go Removed several constants related to ERC20 events and attributes.

Possibly related PRs

🐇 In the meadow, we hop with glee,
ERC20 tokens, as bright as can be!
With bridges and tokens, we dance and play,
Simplified paths light up our way.
Hopping through changes, we cheer and sing,
A world of tokens, oh what joy they bring! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.