PundiAI / fx-core

https://functionx.gitbook.io
Apache License 2.0
21 stars 14 forks source link

refactor: reimplement BridgeTokens gRPC query #748

Closed zakir-code closed 4 days ago

zakir-code commented 5 days ago

Summary by CodeRabbit

coderabbitai[bot] commented 5 days ago

Walkthrough

The pull request introduces significant modifications to the GenesisState structure in the fx.gravity.crosschain.v1 package, including the removal of the BridgeTokens field and adjustments to various other fields. Changes extend to the removal of the bridge_tokens field in multiple blockchain configurations, updates in the Swagger documentation, and alterations in several protocol buffer files. Additionally, method signatures across various components have been updated, primarily involving the reordering of parameters, and several deprecated message definitions have been introduced.

Changes

File Path Change Summary
api/fx/gravity/crosschain/v1/genesis.pulsar.go Removed BridgeTokens field; updated multiple fields with type replacements and repositioning; modified list handling methods.
app/genesis.json Removed bridge_tokens field from multiple blockchain configurations.
docs/swagger-ui/swagger.yaml Removed title: BridgeToken from various locations in the Swagger documentation.
proto/fx/gravity/crosschain/v1/genesis.proto Reordered fields in GenesisState message; removed bridge_tokens and renumbered several fields.
proto/fx/gravity/crosschain/v1/legacy.proto Added deprecated message definitions for BridgeToken, BatchFees, MinBatchFee, QueryBatchFeeRequest, and QueryBatchFeeResponse.
proto/fx/gravity/crosschain/v1/query.proto Added import for legacy.proto; removed QueryBatchFeeRequest and QueryBatchFeeResponse message definitions.
proto/fx/gravity/crosschain/v1/types.proto Removed BridgeToken, BatchFees, and MinBatchFee message definitions; marked oracles field in Params as deprecated.
x/crosschain/keeper/bridge_token.go Reordered parameters in method calls related to erc20Keeper; no changes to exported declarations.
x/crosschain/keeper/grpc_query.go Updated parameter orders in DenomToToken and TokenToDenom; modified BridgeTokens method to accept a request parameter.
x/crosschain/keeper/many_to_one.go Swapped parameter orders in GetBridgeToken and GetIBCToken method calls.
x/crosschain/mock/expected_keepers_mocks.go Reordered parameters in GetBridgeToken and GetIBCToken; added GetBridgeTokens method.
x/crosschain/types/expected_keepers.go Updated parameter orders in GetBridgeToken and GetIBCToken; added GetBridgeTokens method.
x/crosschain/types/types.go Removed BridgeDenomToContract function and its import statement.
x/crosschain/types/types_test.go Removed TestBridgeDenomToContract function.
x/erc20/keeper/bridge_token.go Changed parameter order in GetBridgeToken; added GetBaseDenom and GetBridgeTokens methods.
x/erc20/keeper/ibc_token.go Reordered parameters in GetIBCToken and AddIBCToken methods.
x/erc20/types/events.go Removed constant EventTypeConvertERC20.
x/erc20/types/keys_test.go Deleted the test file, removing TestName function.
x/erc20/types/msg_test.go Removed MsgTestSuite struct; TestMsgConvertCoin function is now standalone.

Possibly related PRs

πŸ‡ In the land of code, where changes unfold,
The BridgeTokens have left, their story retold.
Fields are reordered, and mocks now align,
With tokens and bridges, all working in line.
So hop along, friends, let’s celebrate this feat,
For in every change, our code feels complete! πŸŽ‰


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
πŸͺ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.