Closed zakir-code closed 23 hours ago
The pull request introduces several key changes across multiple files, primarily focusing on the integration of the crosschaintypes
package and enhancements to the upgrade process. Notable updates include new import statements, the addition of module account permissions for cross-chain operations, and the introduction of migration functions for handling bridge token balances. The InitGenesis
function has been modified to retrieve existing module accounts, and new methods have been added to the AccountKeeper
interface. Additionally, adjustments have been made to test cases reflecting changes in expected account states.
File | Change Summary |
---|---|
app/modules.go | - Added import for crosschaintypes . - Updated maccPerms to include crosschaintypes.ModuleName with permissions for minting and burning. |
app/upgrades/v8/upgrade.go | - Added imports for new packages. - Introduced migrateCrosschainModuleAccount , migrateBridgeBalance , and migrateAccountBalance functions for handling module account migrations and balance transfers. - Modified updateMetadata for additional checks. |
client/client_test.go | - Updated expected account sequence numbers in TestClient_Tx . - Changed expected length of accounts in TestClient_GetModuleAccounts . |
x/crosschain/keeper/genesis.go | - Modified InitGenesis to retrieve the existing crosschain module account instead of creating a new one. |
x/crosschain/keeper/keeper.go | - Changed initialization of callbackFrom in NewKeeper to use BridgeCallSender . |
x/crosschain/mock/expected_keepers_mocks.go | - Added GetModuleAccount method to MockAccountKeeper interface for retrieving module accounts. |
x/crosschain/types/expected_keepers.go | - Added GetModuleAccount method to AccountKeeper interface. |
x/crosschain/types/key.go | - Introduced new constant BridgeCallSender . |
x/erc20/migrations/v8/migrate.go | - Modified MigrateToken to include conditions for processing specific tokens. |
x/erc20/migrations/v8/token.go | - Added new IBC denomination trace for "pundix" in both testnet and mainnet maps. |
NewKeeper
function to use BridgeCallSender
, relating to module account handling.crosschaintypes
package.CrossChain
to Crosschain
, aligning with standardization efforts in the main PR.🐇 In the meadow, changes sprout,
New bridges built, no doubt!
With tokens dancing, side by side,
Cross-chain dreams, we now can ride.
Migrations flow, like streams so bright,
A leap for us, into the light! 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
Release Notes
New Features
AccountKeeper
interface.Bug Fixes
Improvements
Documentation