search

PunishXIV / Splatoon

An accessibility tool to assist in FFXIV gameplay and compensate for human imperfections.
https://puni.sh/plugin/Splatoon
GNU Affero General Public License v3.0
209 stars 54 forks source link

added drawing of filled cone for element.type==5 #64

Closed tatad2 closed 4 months ago

tatad2 commented 4 months ago

When i was testing the code, i noticed that when e.FaceMe == true, the sector is growing clockwise, and when e.FaceMe == false, the sector is growing counterclockwise. For example, in the case where the angle of the element is set to -10 ~ 50 and the facing target stands at 0-degree direction, the sector drawn is reversed when e.FaceMe is different. I don't know if this is intentional, so I only implemented the e.type==5 case.

tatad2 commented 4 months ago

Also modified the logic for drawing filled rectangles. Using GetAdjustedLine() to get in-camera lines would cause the rectangle to have clipping issues, so i disabled it when using the filled rectangle. 5DEB856122318473BB8F9683239A5B67

But it also causes a problem that when the camera view is very low, the rendered rectangle may float in the air. However I don't think somebody would play with that low view.

Limiana commented 4 months ago

Thank you! All rendering issues were resolved in testing version actually. But I'll keep this one as legacy as well.