PunishXIV / YesAlready

Clicks Yes in various dialogues you've specified.
https://puni.sh/plugin/YesAlready
102 stars 34 forks source link

Can't make it work with german client #94

Open dasgigi opened 1 year ago

dasgigi commented 1 year ago

So, I play with german language, but cant make this addon work.

German text would be: /Diesen Fang als Sammlerstück einholen? Sammlerwert: .*/

Did I miss something ?

fish1

daemitus commented 1 year ago

Try using the add-last-seen-dialog button, so it picks up the text automatically. I bet its either a unicode problem with the ü or maybe the newline character after einholen?

On Mon, Mar 6, 2023 at 11:31 AM dasgigi @.***> wrote:

So, I play with german language, but cant make this addon work.

German text would be: /Diesen Fang als Sammlerstück einholen? Sammlerwert: .*/

Did I miss something ?

[image: fish1] https://user-images.githubusercontent.com/127131436/223171911-8b6cc7f8-645f-47b3-8cc6-fd52edee6be8.JPG

— Reply to this email directly, view it on GitHub https://github.com/daemitus/YesAlready/issues/94, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFMTBCDBCZB6H4Z3XPIMDLW2YGNJANCNFSM6AAAAAAVRLDXOY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

tmschorr commented 1 year ago

I have tested it, if I use the shorter variant of the text, e.g. 'Diesen Fang als', then it works. But it would be nicer if the corresponding UNICODE is loaded in the program, so that not everyone who uses the German client is dependent on finding out this trick first.

dasgigi commented 1 year ago

I have tested it, if I use the shorter variant of the text, e.g. 'Diesen Fang als', then it works. But it would be nicer if the corresponding UNICODE is loaded in the program, so that not everyone who uses the German client is dependent on finding out this trick first.

Thanks dude, this workaround works like a charm :)

baelrayneVessdren commented 2 months ago

Little late to the party but if someone else sees this, try this for a more generic string. It will let you have differing collectors values: /Diesen Fang als Sammlerstück einholen\? Sammlerwert: [0-9]{1,}/

Also: if the addon uses generic regex, the "?" at the end of the first sentence is the issue. The "?" is an expression in Regex so without the "\" in front of it, it will be treated as a command and not the actual symbol.