search

PunishedPineapple / Distance

Dalamud/XIVLauncher plugin to show basic distance to boss information.
MIT License
10 stars 11 forks source link

The unit of distance #25

Closed xyzsys closed 3 months ago

xyzsys commented 3 months ago

Hi! I would like to be able to use meters instead of yards as the unit of distance to be displayed. Thank you!

PunishedPineapple commented 3 months ago

I am sorry, but the game uses yalms internally and for all tooltips, so showing them as meters would be displaying incorrect values and/or units.

xyzsys commented 3 months ago

Thanks for your reply. Actually, I am a Japanese player and the Japanese version uses "m" for all units.

After reading your reply, I looked at the job guide to see if the English version has different values as well as units, but in fact the values are the same, just the unit notation is different. Therefore, it's fine as is. Thanks again!

PunishedPineapple commented 3 months ago

I see. I have not opened up a non-English client for a while, so I should not have spoken so definitively before looking. I kinda messed up. I will have it match the game client. Having correct units displayed is actually very important to me.

It is very interesting to me that they define yalms and meters as the same, though, when they have ilms, fulms, malms, etc. in the game. Just out of curiosity, are those units used too in the text for the Japanese version of the game, or do they use something else?

xyzsys commented 3 months ago

Wow! Great news for Japanese players (and possibly players from other countries). I'm waiting for the update! Have a nice day!

PunishedPineapple commented 3 months ago

It should now use meters for the Japanese client (German and French appear to use Yalms) in version 1.1.3.0, which just got merged. Please let me know if you find any issues or something that I may have missed.

I apologize again for dismissing this issue without completely looking into it first.

xyzsys commented 3 months ago

Thanks for the ultra fast update. It seems to be working flawlessly. Great job!

After that I noticed that you are also the developer of WaymarkPresetPlugin. Your WPP repository is archived, are you no longer involved in its development?

PunishedPineapple commented 3 months ago

I stopped working on plugins about a year ago, and put all of mine up for adoption then. Someone took over Waymark Preset Plugin and Ready Check Helper at that time, but nobody wanted the other two. I've been doing a little bit of stuff again lately, but those two are under someone else's control now.

xyzsys commented 3 months ago

I see. I'm glad you've resumed development even if only a little, since all the plug-ins you've developed have been excellent. If you ever need Japanese translations, feel free to contact me. Take care!

PunishedPineapple commented 3 months ago

Thank you very much for your kind words! I will look into setting up for translation again once things have slowed down for the patch.