PunishedPineapple / WaymarkPresetPlugin

Dalamud/XIVLauncher plugin to manage waymark presets.
MIT License
38 stars 16 forks source link

Add some preset quickplace waymark presets #27

Closed xiv-stats closed 1 year ago

xiv-stats commented 2 years ago

This adds a couple commonly used waymark presets, so that users don't have to create/import anything to use them. While this functionality does exist already using the /place command, it requires the users to import the waymark presets that they want to place first.

These presets are hardcoded for an arena center of (100, 0, 100), which have been the usual arena centers for all recent content.

PunishedPineapple commented 2 years ago

I won't have time to do anything with this for a couple of weeks probably.

The potential for markers floating in space makes me feel uneasy about this. It probably needs to be able to consistently determine arena center; most is not all (Memoria is the first to mind) when it comes to arenas being centered at 100,0,100. Ideally it would also somehow determine that it's not going to put markers outside of the arena for small-sized arenas. Yes, people can do dumb things with presets too, but it requires more work and thought than someone dropping into an instance and hitting a macro that they think is one size fits all, but plops markers down in the middle of the sky.

Error messages need to be properly keyed for localization.

I won't reject it out of hand, but as I said in Discord, you really should have read the pinned issue before doing this.

PunishedPineapple commented 2 years ago

This will be on hold indefinitely after SE punishing someone for using OOB waymarks. If checking for OOB can be easily implemented, I'll take another look at it.

PunishedPineapple commented 1 year ago

This plugin has changed ownership, and I am no longer maintaining it.