search

PunishedPineapple / WhatDidYouSay

Dalamud/XIVLauncher plugin to print NPC speech bubbles to the chat log.
MIT License
3 stars 1 forks source link

Atticus the Primogenitor speech bubbles all appear over central head #6

Open bethsmoothmove opened 3 months ago

bethsmoothmove commented 3 months ago

Dawntrail S rank tell is speech bubbles over left, right and middle heads to show cleave order. When this plugin is enabled, all of the speech bubbles all appear over the central head.

"Chat Bubbles" plugin also has this issue. Only with both disabled can the boss be fought properly.

PunishedPineapple commented 3 months ago

I took the current bubble open sig from Chat Bubbles, so it is not surprising that both have the issue. Unfortunately, I will not be able to troubleshoot for a few days probably. I also do not know how to test this, since making it to a specific S rank is spotty at best. I wonder if there are other NPCs anywhere that share this behavior.

Regardless, I will try to look into it and see if the function is missing a parameter that it needs to forward in the hook or something. I am very sorry for the inconvenience.

PunishedPineapple commented 3 months ago

Open bubble delegate does seem to be missing a parameter, but unable to test with that fix so far. Corresponding Chat Bubbles issue is https://github.com/Haplo064/ChatBubbles/issues/63

PunishedPineapple commented 3 months ago

There is a testing release (v1.0.2.4) for this plugin that was just merged. Hopefully it fixes the issue. Chat Bubbles (its current version, anyway) will need to be disabled if testing this issue.

PunishedPineapple commented 3 months ago

@alvisdotexe Can you confirm whether you were on the current testing version (1.0.2.4) when checking this? Looking at recent Chat Bubbles changes, both plugins did the same thing to fix this.

alvisdotexe commented 3 months ago

I'm just really stupid and didn't double check, sorry for making it seem there was anything wrong.

PunishedPineapple commented 3 months ago

No worries at all. I was just going to be very confused. Considering that it is confirmed fixed with Chat Bubbles, I will swap this from testing to stable in a bit.