search

Punpun1643 / pe

0 stars 0 forks source link

Wrong variable type being passed in the sequence diagram for `deleteJob()` #15

Open Punpun1643 opened 2 years ago

Punpun1643 commented 2 years ago

D7C2604D-8F9D-474E-85BC-811BF0C454FB_4_5005_c.jpeg

deleteJob() method takes in parameter with the type Job. However in the sequence diagram below you take in Index as an argument i.e. deleteJob(1) 1 is an Index not a Job so should have been deleteJob(j) instead if you wish to keep the diagram at high level. Doing deleteJob(1) might be misleaded as the method takes in Index not Job.

210637C4-B8B4-48FA-AED2-C499240858C4_4_5005_c.jpeg

Severity low and not verylow as the information provided is misleading and it is not merely cosmetic issue.

nus-pe-script commented 2 years ago

Your response not required for this bug as the team has accepted the bug as it is.