search

Punpun1643 / pe

0 stars 0 forks source link

Able to edit person to have all attributes the same #9

Open Punpun1643 opened 2 years ago

Punpun1643 commented 2 years ago

Explanation: Step 1:

personadd n/Nicole Tan p/99338558 e/nicole@stffhub.org a/1 Tech Drive, S138572 r/37.50 t/Hardware t/Senior

7316B93D-1E69-4066-A715-5E2BB726CB9F.jpeg

Step 2: personadd n/nicole Tan p/99338558 e/nicole@stffhub.org a/1 Tech Drive, S138572 r/37.50 t/Hardware t/Senior

131CFBAA-BF68-46F1-A6BF-40212ED0E408.jpeg

Step 3: personedit 7 n/Nicole Tan

F4FD6B8E-1BB2-47D8-9C57-1F3F8CC372D4.jpeg

Now the app can have two person with all attributes the same even the names.

Severity: Medium

Justification: The intention during implementation would likely be no two employee with all extact same attributes being able to be added to the app, based on the error message shown in the app when tried adding duplicate employees. Edit should have thrown error when trying to edit a person to be of the same identity as another person. Its not severity low as editing a person name is not uncommon and user would likely not remember about the attributes of other added employee in the list to know whether the contact to be edited will end up having the same identity with someone else in the list.

nus-pe-script commented 2 years ago

Team's Response

We were able to reproduce this issue, and we acknowledge that it does occur.

However, the bug occurs in rare cases and is unlikely to affect normal use. Unlike stated in the justification, editing a person's name is uncommon. It is rare for an individual to have a name change, the only likely case where a name needs to be edited is when the user initially keys in the name wrongly, or keys in an incomplete name. Furthermore, it is unlikely that a user will make significant changes when editing a person, meaning it is unlikely for a user to edit all attributes to match the attributes of an existing person. This situation is more likely to occur with a malicious user that intentionally sabotages the data, rather than a regular user. The most likely cause for error is if a user mistakenly adds the same person twice, but makes a small typo in one of the attributes of one person. This results in two entries in the database. The user would then edit the typo to match the other person. However, similar to other contact management apps that can handle duplicate names, it is the onus of the user to ensure that they have keyed in the details correctly. Not to mention, in searching for the index of the person with the typo, the user is likely to come across the correct duplicated entry, leading the user to delete the incorrect duplicated entry.

Thus, based on the description of the low and medium severity levels in the PE guide:

  • severity.Low : A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.
  • severity.Medium : A flaw that causes occasional inconvenience to some users but they can continue to use the product.

We believe this qualifies as a low severity issue, and not a medium severity issue.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]