Punzo / SlicerAstro

Astronomy (HI) extension for 3DSlicer (https://www.slicer.org/)
BSD 3-Clause "New" or "Revised" License
39 stars 7 forks source link

Update to last version of 3DSlicer #106

Closed Punzo closed 4 years ago

Punzo commented 4 years ago

Here a list of bugs to fix (and enhancement) to update SlicerAstro to the current version of 3DSlicer (https://github.com/Slicer/Slicer/commit/55fc1d77b0e86e532c0a0f70a4bb75e4c7eb5856 ; 26/11/2019):

High priority:

Low priority:

Punzo commented 4 years ago

@vdhulst if you have more please add in this issue.

I'll address this issue during the 3DSlicer project week (20-24 January)

vdhulst commented 4 years ago

Downloaded Slicer version 4.11.0-2019-11-28 r28658 and run it under MacOS 10.13.6

Upon startup the following error message appears: (base) JMs-MacBook-Pro:apersched vdhulst$ When loading module "CropVolume" , the dependency "ResampleScalarVectorDWIVolume" failed to be loaded. Switch to module: "AstroVolume"

In the Astro Volume module: changing the transfer function of the 2D display using the cursor within the 2D display window does not work anymore. The slide bars in the menu do work.

Punzo commented 4 years ago

Upon startup the following error message appears: (base) JMs-MacBook-Pro:apersched vdhulst$ When loading module "CropVolume" , the dependency "ResampleScalarVectorDWIVolume" failed to be loaded. Switch to module: "AstroVolume"

if you use only the modules as listed in https://github.com/Punzo/SlicerAstro/wiki/Get-SlicerAstro#get-slicerastro-from-the-3dslicer-website, that error will not show up. We do not use the CropVolume, which depends on a CLI module (ResampleScalarVectorDWIVolume is a CLI module) and these last you probably have already disabled.

In the Astro Volume module: changing the transfer function of the 2D display using the cursor within the 2D display window does not work anymore. The slide bars in the menu do work.

that's acutally a new feature, now there are interactive widgets (points, lines, closed curves etc...) which interact with left click. Therefore, for avoiding miss clicks, now you need to activate the 2d color function change with left click and drag on 2D views by clicking on the mouse pointer in the main controller bar (nearby the widgets controller, see image below).

image

Punzo commented 4 years ago

@vdhulst the commit https://github.com/Punzo/SlicerAstro/commit/42c0799c04fbe10b3696915ed89be2ff3baad70f uses the new widget that I and @lassoan developed last year in the PVSlice module. The new line widget shows much better perfomance; and now (in addition to the single left click and drag) with middle click and drag it allows to shift the full widget (I'll update the module wiki as well).

Punzo commented 4 years ago

@vdhulst last two points (wcslib for windows and update 3DBarolo to 1.5) will be left for later. I'll close this issue (and open two for teh remaining points). If you will experience bugs related to the recent commits, please open new tickets.