Punzo / SlicerAstroApp

Astronomy (HI) customization of 3DSlicer with SlicerAstro (https://github.com/Punzo/SlicerAstro)
Other
1 stars 0 forks source link

SlicerAstro features that stopped working with Slicer #4

Open vdhulst opened 1 year ago

vdhulst commented 1 year ago

The most recent Slicer release (5.3.0-2022.12.30) does not allow adding SlicerAstro as an extension. This has been the case since ~September 2022. The last version I still have with parts of SlicerAstro functional is Slicer_4.13.0-2022-01-26. In this version loading, manipulating the display settings, smoothing the data, masking the data using the lasso tool work fine. Once segmentations are defined, determining rms, mean, fluxes, etc. moment maps and profiles using the segmentation as selections works fine.

What fails are the PV Diagram and PV Slice tools. With these the systems just hangs and then crashes. The first phase of drawing the lines along which the PV slices are evaluated does not start at all.

Also the 3DBarolo modelling is not working well. I could not manage to get a proper solution on a masked data set.

I did not try the reprojection.

Not sure what the important steps are to get SliceAstro in line with the current Slicer Core. @Punzo: let me know if I can do anything in addition to testing and collecting the sample data.

Punzo commented 1 year ago

Thanks for testing!

The most recent Slicer release (5.3.0-2022.12.30) does not allow adding SlicerAstro as an extension. This has been the case since ~September 2022. The last version I still have with parts of SlicerAstro functional is Slicer_4.13.0-2022-01-26. In this version loading, manipulating the display settings, smoothing the data, masking the data using the lasso tool work fine. Once segmentations are defined, determining rms, mean, fluxes, etc. moment maps and profiles using the segmentation as selections works fine.

yes, unfortunately SlicerAstro does not work from Slicer 5 and up.

What fails are the PV Diagram and PV Slice tools. With these the systems just hangs and then crashes. The first phase of drawing the lines along which the PV slices are evaluated does not start at all.

This is related to modifications to the markups infrastructure. It should be straightforward to fix it, but I need to check.

Also the 3DBarolo modelling is not working well. I could not manage to get a proper solution on a masked data set.

uhm, probably the best it would to get rid of the old custom version that we have (1.3).

One strategy could be to run the binaries as they are, as a separate thread in the command line (and comunicate with the GUI by input/output files). The main issue in using this strategy would be the memory usage (it will be the double).

Or we could try the Barolo Python API.

In general I would need to investigate what is the status now of the package.

I did not try the reprojection.

ok

Not sure what the important steps are to get SliceAstro in line with the current Slicer Core. @Punzo: let me know if I can do anything in addition to testing and collecting the sample data.

I would need to try to compile on the lastest Slicer 5 and fix all the compilation issues and then we would need to test it again.

Between Slicer 4 and 5 there some not backward compatible updates that we have to look for.

I will try to do it as soon as I have some free time.

Punzo commented 1 year ago

few info:

1) page for the project week for SlicerAstro update is here https://projectweek.na-mic.org/PW38_2023_GranCanaria/Projects/SlicerAstroUpdate/

2) some modules use the AnnotationROI class. This has been deprecated and probably that parts do not work

3) there are also issues listed in the SlicerAstro extension repo: https://github.com/Punzo/SlicerAstro/issues

Punzo commented 1 year ago

@vdhulst I fixed the compilation, but there are still many parts broken. I have listed all the info here: https://github.com/NA-MIC/ProjectWeek/blob/master/PW38_2023_GranCanaria/Projects/SlicerAstroUpdate/README.md#progress-and-next-steps

I will try to find time to fix everything after the project week.