search

PurdueMarketingAndMedia / purdueTemplates-2015

Included in this project are the Purdue University templates developed by the Office of Marketing and Media in 2015.
14 stars 7 forks source link

Feat/add browser compatibility #101

Closed jyoung295 closed 5 years ago

jyoung295 commented 5 years ago

Moving #100 to this pull request to change branch name.

jyoung295 commented 5 years ago

Safari is having a really weird visual bug with the YouTube video in the side content. Also in the side nav the gold underline is not working, see gif:

Image from Gyazo

jyoung295 commented 5 years ago

Accordions on the example page are snapping closed instead of sliding closed like the ones in the footer.

jyoung295 commented 5 years ago

Edge (left) and Chrome (middle) render the image differently than Firefox (right).

Image from Gyazo

The image is being stretched vertically on all browsers, but appears even more stretched on chromium browsers.

jyoung295 commented 5 years ago

Edge (left) and Chrome (middle) render the image differently than Firefox (right).

Image from Gyazo

The image is being stretched vertically on all browsers, but appears even more stretched on chromium browsers.

This has been fixed in afb7b30

jyoung295 commented 5 years ago

Safari is having a really weird visual bug with the YouTube video in the side content. Also in the side nav the gold underline is not working, see gif:

Visual Bug with the video player is still there, but the missing underline has been fixed in d830d04

jyoung295 commented 5 years ago

We should think about re-working the button styles too because Jacob built them with pseudo-elements because it makes it easy to create slimmer and wider buttons with differing amounts of space, but when we were originally discussing the buttons, I had suggested just using flex, but it seemed Jacob was set on the pseudo element version.

The way they're currently built, they work in IE but don't have the same spacing inside the button because pseudo elements can be tricky in IE.

jyoung295 commented 5 years ago

Here on Codepen you can see an example I wrote for the first two sets of buttons of what I think is a better way to write them.

Yanhuazong commented 5 years ago

Safari is having a really weird visual bug with the YouTube video in the side content. Also in the side nav the gold underline is not working, see gif:

Image from Gyazo

Aug-09-2019 09-49-09 This seems to only happen on additional monitors. On the monitor of my laptop the visual bug doesn't show up.

jyoung295 commented 5 years ago

Weird, well it must be a Safari bug so there's nothing we can do about it.