search

Pure-D / workspace-d

CLI deprecated, API + functionality moved into https://github.com/Pure-D/serve-d
MIT License
75 stars 15 forks source link

Fix some memory leak issues #100

Closed dayllenger closed 4 years ago

dayllenger commented 4 years ago

Rollback allocators leak. I moved them into the scopes they are used in. I tried to set checkpoint + rollback on scope exit, but got segfault. Bringing them in scope is maybe slower (without a benchmark it's nonsensial to say), but at least it is safe.

Futures leak too. They need to join threads explicitly.

WebFreak001 commented 4 years ago

have you tried latest libdparse yet? I have redone the rollback allocator implementation and it was PRd recently (not yet upgraded)

before it would segfault on a lot of operations, now it should work fine

dayllenger commented 4 years ago

I forgot. Now they work. I'll test more and submit a PR tomorrow.