WebFreak001
commented
6 years ago Uglified my git history a bit but pushed my fix anyway. It instead only renamed full to extended and kept the auto detect for new version as it only adds new fields and does not alter any old fields.
If you have any case where this breaks old behaviour please bring it up. Otherwise I am closing your PR now because it is implemented in another way in master. But still a big thank you for contributing to workspace-d.
oh I'm pretty sure that this won't break anything though because it just added new fields, so I think you should rather keep the existing check for extended mode because it is backwards compatible. However I had --full in there because that was pre-PR I made to dcd, so just replacing with extended should be enough.
That said I actually had this fixed already but I forgot to push it, but I forgot to pull before change so it would require a rebase or merge, so I think if you instead made this to use extended depending on if it is supported instead of adding a new feature-flag I would merge this. The whole idea behind workspace-d was after all that you could update workspace-d and it would update capabilities in existing plugins without the need of upgrading them (or very little at least)