search

Pure-Storage-Ansible / FlashArray-Collection

Ansible Collection for Pure Storage FlashArray
GNU General Public License v3.0
18 stars 22 forks source link

No 'http' proxy supported #419

Closed sanderdescamps closed 1 year ago

sanderdescamps commented 1 year ago

Is your feature request related to a problem? Please describe. As far as I can see in the code, the proxy module only supports https proxies. It is not possible to configure a http proxy. I know it is always better to use https but my case I don't have any control on it. So it would be nice if this could be added.

https://github.com/Pure-Storage-Ansible/FlashArray-Collection/blob/86a9f9eac37db045dbca17bda725639ef7846d11/plugins/modules/purefa_proxy.py#L89C1-L91C10

Describe the solution you'd like Add a parameter where I can select the protocol. Options should be one of httpand https. With httpsas default to ensure backwards compatibility.

sdodsley commented 1 year ago

@sanderdescamps please try patch #420