Closed dbuenoparedes closed 1 year ago
Forgot to mention that I'm using the 5.2.0 or higher purefa_ds module approach as I'm testing this with Pure arrays running version 6.4.x.
This module is not idempotent because of the password field. We have no way to know if the password you enter is the same as the original for security reasons. No module that passes a password can be idempotent.
Ok, understood @sdodsley, sorry that I wasn't aware of that implementation.
I do have to mention that I had to add the no_log: true
to the purefa_user module because it wasn't implemented with this same approach. You might want to revisit that one just in case.
Thanks,
no_log
is defined for password
and old_password
in purefa_user
.
Which other parameter would you want no_log
on?
I think you're right, purefa_user
uses the password
/old_password
approach whereas purefa_ds
is just bind_password
(there's no old_bind_password
if you want to change it).
I'm good to close this issue, no bug or change needed here.
Thanks for your feedback!
Describe the bug When running a task that uses purefa_ds module, the first time it runs it properly configures the settings. Running it a 2nd or 3rd... times it'll trigger a change cause it shows on each run
changed: [us1pure01] => changed=value_specified_in_no_log_parameter
)To Reproduce I'm using a basic configuration task for this module:
Expected behavior If there isn't any change in the variables/values 2nd and consecutive runs shouldn't show any "changed" output when ansible runs.
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
/home/dbuenoparedes/.ansible/collections/ansible_collections
Collection Version
purestorage.flasharray 1.17.2