Pure-Storage-Ansible / FlashArray-Collection

Ansible Collection for Pure Storage FlashArray
GNU General Public License v3.0
18 stars 22 forks source link

purefa_certs is not taking care of change in state:sign #430

Closed pda79 closed 1 year ago

pda79 commented 1 year ago

when you use purefa_certs and you decide to change a parameter, the previous conf is used this is the case for all parameter of sign request (common_name, country, email, locality, province, organization, org_unit)

To Reproduce Steps to reproduce the behavior: use purefa_certs: state: sign org_unit: "new_org_unit"

Expected behavior a signing request with the good parameter

Additional context purestorage 1.19.0 py-pure-client 1.33.1

sdodsley commented 1 year ago

@pda79 please try PR #433 to see if this resolves your issue and let me know.

pda79 commented 1 year ago

@sdodsley i have made a try but it seems that it works worse. take a look at thit screenshot 2023-07-28 11_20_36-Clipboard

sdodsley commented 1 year ago

@pda79 OK - will fix that and get a new update later today

sdodsley commented 1 year ago

@pda79 Please try this new verson

pda79 commented 1 year ago

@sdodsley this new version is working but with this new version i have found another bug in this use case: purefa_certs: generate: true 2023-07-28 16_04_59-2023-07-28 15_59_48-PWVD1410 - Poste de DEV Windows - Desktop Viewer

sdodsley commented 1 year ago

@pda79 give the latest a try - hopefully this catches everything now

pda79 commented 1 year ago

@sdodsley great all is working fine. Good job and well done. Thanks a lot

sdodsley commented 1 year ago

No problem. Thank you for finding the problem.