search

Pure-Storage-Ansible / FlashArray-Collection

Ansible Collection for Pure Storage FlashArray
GNU General Public License v3.0
18 stars 22 forks source link

Snap fix #436

Closed genegr closed 1 year ago

genegr commented 1 year ago
SUMMARY

Fixed #435

ISSUE TYPE
COMPONENT NAME

purefa_snap

ADDITIONAL INFORMATION
sdodsley commented 1 year ago

@genegr please add a release note

genegr commented 1 year ago

Yep, tested all the combinations of automatically and user assigned postfix and it worked. It is mainly a workaround to the response error returned by the volumes API 1.x. A normal query for a remote snapshot returns an error with the specific reason that is a remote volume snapshot, while with the wildcard '*' it matches all the snapshots for the volumes, without taking into consideration they are remote or local.

On Mon, Aug 14, 2023 at 9:18 PM Simon Dodsley @.***> wrote:

@.**** approved this pull request.

No position to test but I assume you have tested multiple scenarios...

— Reply to this email directly, view it on GitHub https://github.com/Pure-Storage-Ansible/FlashArray-Collection/pull/436#pullrequestreview-1577495971, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGNLRLZ4755BKRVEO5GJUB3XVJ2X7ANCNFSM6AAAAAA3P6JPPU . You are receiving this because you authored the thread.Message ID: <Pure-Storage-Ansible/FlashArray-Collection/pull/436/review/1577495971@ github.com>

genegr commented 1 year ago

Done. Added the proper changelog fragment file

On Mon, Aug 14, 2023 at 9:19 PM Simon Dodsley @.***> wrote:

@genegr https://github.com/genegr please add a release note

— Reply to this email directly, view it on GitHub https://github.com/Pure-Storage-Ansible/FlashArray-Collection/pull/436#issuecomment-1677926403, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGNLRLYE4DEV54BNXMTVHY3XVJ22TANCNFSM6AAAAAA3P6JPPU . You are receiving this because you were mentioned.Message ID: @.*** com>

sdodsley commented 1 year ago

Changelog fragments needs to be a .yml fe