Pure-Storage-Ansible / FlashArray-Collection

Ansible Collection for Pure Storage FlashArray
GNU General Public License v3.0
19 stars 21 forks source link

unable to update network interface with no IP address set #472

Closed tylergmuir closed 9 months ago

tylergmuir commented 9 months ago

Describe the bug When you have an interface that you want to update without an IP address set, say in the case you are changing the services. The purefa_network module fails with an error that state "failed to detect a valid IP". A workaround is to set the address to 0.0.0.0/0 but this results in the module reporting changed every time.

To Reproduce Steps to reproduce the behavior:

  1. Have an interface that doesn't have an IP address set.
  2. Attempt to set only the services and/or MTU of the interface and do not specify the address or gateway parameters.

Expected behavior The expected behavior is that the network interface would be updated as it is a valid state to have no address assigned.

sdodsley commented 9 months ago

@tylergmuir Try #471 to see if that has helped.

tylergmuir commented 9 months ago

@sdodsley #471 does fix this issue.

sdodsley commented 9 months ago

@tylergmuir purefa_network changes backed out of this change and moved to #474