Multiple network module fixes/changes

[sdodsley]

SUMMARY

Add support for interface parameter with options of vif, lacp. New, associated, parameters of subinterfaces for interface type of vif and subordinates of interface type lacp.

Add parameters enabled (default True) and subnet.

Closes #466 Closes #473 Closes #472 Closes #391

ISSUE TYPE

• Bugfix Pull Request
• Feature Pull Request

COMPONENT NAME

purefa_network.py

[tylergmuir]

From my testing, this doesn't appear to fix #473. I think the issue is that the address that is being past in is 0.0.0.0/0 but the pure array returns None. Same goes for the gateway.

In quickly looking over the code, I don't see a great way to fix this other than just doing another set of if statements, but I could be overlooking something.

[sdodsley]

I'll take another look at it

[sdodsley]

@tylergmuir I think that gets it now. Please let me know if your testing is successful or not.

[tylergmuir]

@sdodsley That did fix the reporting on the interfaces. But I just tested updating an existing vif and it failed. Collecting more info to provide now and will have that to you shortly.

[sdodsley]

@tylergmuir @ryuyamag I think this now fixes all your concerns.

[tylergmuir]

@sdodsley It looks like the configuration for the vif is applying correctly now, but it is always reporting as changed.

[sdodsley]

@tylergmuir can you give an example task that is reporting idempotency incorrectly

[tylergmuir]

@sdodsley this is the basis of what I am doing

- name: Configure vif for file
  purestorage.flasharray.purefa_network:
    name: filevif
    servicelist:
      - file
    interface: vif
    subinterfaces:
      - eth4
      - eth5
    address: "{{ ip_cidr }}"
    gateway: "{{ gateway }}"
    mtu: 1500

[sdodsley]

@tylergmuir ok - fixed it... Hopefully this is the last iteration. I never want to see this module again :)

[tylergmuir]

@sdodsley It works! I ran a few more tests with different configs and it did what I expected it to do each time.

[ryuyamag]

@sdodsley

very sorry, it seems that two functions do not work.

1. clear address ipv4&ipv6 failed to detect a valid IP

2. clear gateway ipv4&ipv6 changed:true appears, but it's not changed.

I have attached the log file network2.zip

[sdodsley]

@ryuyamag I think I got it now. Please try all your tests and let me know how it goes. @tylergmuir please confirm this last fix didn't break anything in your tests.

[ryuyamag]

@sdodsley I had to modify some Playbooks this time, but I can confirm that everything works fine. thank you.

[tylergmuir]

@sdodsley looks good on my side too.