search

Pure-Storage-Ansible / FlashArray-Collection

Ansible Collection for Pure Storage FlashArray
GNU General Public License v3.0
19 stars 21 forks source link

Fix pgsnap issue not replicating correctly #483

Closed sdodsley closed 9 months ago

sdodsley commented 9 months ago
SUMMARY

Fixes #478

ISSUE TYPE
COMPONENT NAME

purefa_pgsnap.py

ryuyamag commented 9 months ago

Considering the modified code, is it correct to have "replicate=true" in case of "now:false remote:true"?

This patch did not work in my environment. The fix may only be included in arrayv6.

sdodsley commented 9 months ago

@ryuyamag I think the issue is that remote and now should be mutually exclusive and you only need to set either to True, with False being the default. Therefore there are only 2 options possible.

sdodsley commented 9 months ago

@ryuyamag please try this version.

ryuyamag commented 9 months ago

I tested with this patch, I think this issue was fixed and can be closed.

However, "replicate" and "replicate_now" seemed to have the same behavior on RestAPI side. "replicate" will not be queued up and the replicating at the same time as earlier replication sessions.

-- pureeng@japan-pslab-ct0:~$ purepgroup list --snap --transfer array1:yamapg Name Source Created Started Completed Progress Data Transferred Physical Bytes Written array1:yamapg.p2 array1:yamapg 2023-10-19 11:25:22 JST 2023-10-19 11:25:22 JST - 7.50% 553.80M 406.01M array1:yamapg.p1 array1:yamapg 2023-10-19 11:23:54 JST 2023-10-19 11:23:54 JST - 7.54% 316.98M 245.07M array1:yamapg.1174 array1:yamapg 2023-10-19 11:22:27 JST 2023-10-19 11:22:27 JST - 7.68% 2.75G 2.59G

sdodsley commented 9 months ago

@ryuyamag all we can do with Ansible is use the API endpoints. If they are not doing what they should, then that would be an issue for Purity engineering to look into.