purefa_network module not idempotent when creating LACP bond interfaces

[dbuenoparedes]

Describe the bug When I try to configure a LACP bond (lacp0) with 2 subordinates (ct0.eth14 and ct0.eth15) it successfully creates them but when I run the same task against an array that has already configured lacp0 bond with the same subordinates interfaces I get the following error:

failed: [us1pure01] (item={'name': 'lacp0', 'type': 'lacp', 'enabled': True, 'subordinates': ['ct0.eth14', 'ct0.eth15'], 'mtu': 9000}) => changed=false 
  ansible_facts:
    discovered_interpreter_python: /usr/bin/python3
  ansible_loop_var: net
  msg: Subordinate ct0.eth14 does not exist. Ensure you have specified the controller.
  net:
    enabled: true
    mtu: 9000
    name: lacp0
    subordinates:
    - ct0.eth14
    - ct0.eth15
    type: lacp

To Reproduce Steps to reproduce the behavior:

1. Create a simple task with purefa_network with the attributes shown in the previous error
2. See error

Expected behavior It should show that existing lacp0 interface is already created with the chosen subordinates interfaces.

Environment (please complete the following information):

• ansible core v2.16.7
• purestorage.flasharray v1.28.0
• Purity OS v6.4.9

Additional context This could have something to do that with the CLI the interfaces already configured to be part of a LACP bond are missing from the list of available individual interfaces but they still show up as "subinterfaces" of the bond:

dbuenoparedes@us1pure01> purenetwork eth list --service iscsi
Name      Enabled  Type       Subnet  Address  Mask  Gateway  MTU   MAC                Speed       Services  Subinterfaces
ct0.eth4  False    physical   -       -        -     -        1500  <redacted_MAC_address>  25.00 Gb/s  iscsi     -
ct0.eth5  False    physical   -       -        -     -        1500  <redacted_MAC_address>  25.00 Gb/s  iscsi     -
ct1.eth4  False    physical   -       -        -     -        1500  <redacted_MAC_address>  25.00 Gb/s  iscsi     -
ct1.eth5  False    physical   -       -        -     -        1500  <redacted_MAC_address>  25.00 Gb/s  iscsi     -
lacp0     True     lacp_bond  -       -        -     -        9000  <redacted_MAC_address>  20.00 Gb/s  iscsi     ct0.eth14
                                                                                                                  ct0.eth15
lacp1     True     lacp_bond  -       -        -     -        9000  <redacted_MAC_address>  20.00 Gb/s  iscsi     ct1.eth14
                                                                                                                  ct1.eth15

[sdodsley]

We are aware of issues in this module and are in the process of squashing some bugd. Stand by.

[sdodsley]

@dbuenoparedes please check pathc #583 to see if this resolves your issue and let us know.

[dbuenoparedes]

@sdodsley I've just tested it and it partially works now, it picks up the existing lacp bond although if I change the variable that defines the underlying subordinates (subinterfaces) it doesn't detect this, seems to be just checking for existing lacp interfaces.

[sdodsley]

@dbuenoparedes please try again. Updated the patch.

[dbuenoparedes]

@sdodsley thanks, I just tried the new file but now on an array where I already have the interfaces the way I want:

• I'm getting an error that the "subordinate does not exist" on the lacp interfaces and "Child subinterface lacp0 does not exist" when it tries to create the filevif inteface (using lacp0 and lacp1 as subinterfaces).

  
  TASK [purestorage : Configure network interfaces for NFS] **********************************************************************************************************************************************************************
  Tuesday 18 June 2024  09:48:58 -0400 (0:00:00.038)       0:00:00.038 ********** 
  failed: [us1pure01] (item={'name': 'lacp0', 'type': 'lacp', 'enabled': True, 'subordinates': ['ct0.eth14', 'ct0.eth15'], 'mtu': 9000}) => changed=false 
  ansible_facts:
  discovered_interpreter_python: /usr/bin/python3
  ansible_loop_var: net
  msg: Subordinate ct0.eth14 does not exist. Ensure you have specified the controller.
  net:
  enabled: true
  mtu: 9000
  name: lacp0
  subordinates:
  - ct0.eth14
  - ct0.eth15
  type: lacp
  failed: [us1pure01] (item={'name': 'lacp1', 'type': 'lacp', 'enabled': True, 'subordinates': ['ct1.eth14', 'ct1.eth15'], 'mtu': 9000}) => changed=false 
  ansible_loop_var: net
  msg: Subordinate ct1.eth14 does not exist. Ensure you have specified the controller.
  net:
  enabled: true
  mtu: 9000
  name: lacp1
  subordinates:
  - ct1.eth14
  - ct1.eth15
  type: lacp
  failed: [us1pure01] (item={'name': 'filevif', 'type': 'vif', 'enabled': True, 'address': '<redacted IP address>/24', 'gateway': '<redacted gw address>', 'servicelist': 'file', 'subinterfaces': ['lacp0', 'lacp1'], 'mtu': 1500}) => changed=false 
  ansible_loop_var: net
  msg: Child subinterface lacp0 does not exist
  net:
  address: <redacted IP address>/24
  enabled: true
  gateway: <redacted gw address>
  mtu: 1500
  name: filevif
  servicelist: file
  subinterfaces:
  - lacp0
  - lacp1
  type: vif

PLAY RECAP ***** us1pure01 : ok=0 changed=0 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0

On an array where I still haven't configure these network interfaces:

- the lacp interfaces seem to be fine as well as the filevif (dry run fails because I haven't created the lacp subinterfaces on this array yet)

[dbuenoparedes]

@sdodsley NVM my last comment, I wasn't using the right updated purefa_network.py file, got my collection install mixed up.

I've just tested it again with the latest patch you provided and it works as expected.

Sorry for that and thank you!