Pure-Storage-Ansible / Fusion-Collection

Ansible Collection for Pure Fusion
GNU General Public License v3.0
5 stars 11 forks source link

Update fusion backend version #164

Closed LukasZahradnik closed 11 months ago

LukasZahradnik commented 1 year ago
SUMMARY

This PR updates the version format of the backend to more generic "v1".

COMPONENT NAME

module_utils/fusion.py

andreepyro commented 1 year ago

@dimleevik Isn't the endpoint 1.2 now? https://github.com/PureStorage-OpenConnect/fusion-python-sdk/blob/1b801fc4da76ebdf591df222d1cb2e61238fe688/fusion/configuration.py#L49C9-L49C9

LukasZahradnik commented 1 year ago

@andreepyro /v1 is an alias for /1.x. So it shouldn't matter. Although we should update specs so generated files also have the /v1 version

andreepyro commented 1 year ago

@dimleevik you're right I thought the change is from 1 to 1.1

However, I believe we depend on Fusion API 1.2 release, right? Then we should change the ansible prerequisite in plugins/module_utils/prerequisites.py file to ("fusion", "purefusion", ">=1.2.0,<2.0"),

LukasZahradnik commented 1 year ago

@andreepyro Right. I think we should somehow automate this instead of looking for hidden versions.

The wrong version is also in README..

dimleevik commented 1 year ago

@andreepyro, @LukasZahradnik AFAIK /v1 is alias for /latest which is alias to /v1.2

dimleevik commented 1 year ago

@andreepyro, @LukasZahradnik Actually for this change we don't need to change python version, this change works with all versions, since we only provide hostname to sdk, so it will send requests to server with /v1 suffix

github-actions[bot] commented 11 months ago

Stale pull request message