search

PureCarsLabs / css-scroll-snap-polyfill

JS polyfill for CSS scroll snap points.
MIT License
49 stars 6 forks source link

Remove the scroll to end short cut in getNextElementSnapPoint #7

Open bcbrian opened 6 years ago

bcbrian commented 6 years ago

While the short cut to quickly calculate the snap position is a great idea it has one flaw. I fails if the last snapElement is display:none

Example here

Just scroll really hard to the end in the above to observe the bug.

I have removed it in my fork and all is well...

Again willing to pr and brain storm other scenarios... like may do a quick search for the last visible one? that might be a tiny bit faster than the login below...