search

PureStorage-OpenConnect / FlashStache

One-step configuration for automating array querying, storing the query results, and visualizing them with Grafana
Apache License 2.0
4 stars 0 forks source link

setup.sh not explicit to python2 pip #4

Closed bubthegreat closed 7 years ago

bubthegreat commented 7 years ago

Where pip is defaulting to 3.5 in some distros, or might for other configurations on ubuntu server boxes, the setup.sh needs to be explicit in which it's using. Currently, setup.sh expects that we are running python 2.7.x, so running with python3 pip inadvertently will cause dependency failures during install.

micheal.taylor@bubdev:~/FlashStache$ pip --version
pip 9.0.1 from /usr/local/lib/python3.5/dist-packages (python 3.5)
micheal.taylor@bubdev:~/FlashStache$ pip2 --version
pip 9.0.1 from /usr/local/lib/python2.7/dist-packages (python 2.7)
bubthegreat commented 7 years ago

This may be due to other reasons, like people modifying pip to use pip3, etc. Since our dependencies are linked to this, we should use a requirements.txt, and ensure that pip is the correct version for the install as well.

richimus123 commented 7 years ago

We may deprecate this in favor of the OVA method instead of an install script, however we can easily change the setup.sh script to use pip2 instead of pip to prevent conflicts like this. However, in the longer term we may go with Python3 anyway. I'll create a quick fix-up for use pip2 for the short term.