PureStorage-OpenConnect / powershell-toolkit

The Pure Storage PowerShell Toolkit provides a number of different cmdlets ranging from core Windows Server, WMI, WSMAN, & .NET assemblies. The intention of the toolkit is to provide a library for customers and the Pure Storage field to use in troubleshooting, FlashArray reporting & other useful scenarios.
Apache License 2.0
22 stars 6 forks source link

HotFix reporting issues with Test-WindowsBestPracitces #11

Closed barkz closed 6 years ago

barkz commented 7 years ago

Seeing an issue with how the script runs and reports the Hotfix information. We ran the Best Practice Analyzer script here and are getting a WARNING: INSTALLED message which appears to be misleading. We are on 2012 R2 and it is warning: HotFix Information

WARNING: Installed -- KB2919355 WARNING: Installed -- KB3000850 WARNING: Installed -- KB3013769 WARNING: Installed -- KB2990170 The Best Practices Guide only shows 1 KB necessary: Windows Server 2012 R2 KB2990170 The WARNING Installed seems misleading as it conveys that something is wrong when it is confirming that the Hotfix is installed. Can we ensure that the script only searches for the single Hotfix required for 2012 R2? Also can we ensure that the message if it is installed is a positive one not something that conveys a need for action?

barkz commented 6 years ago

See Issue 9 for reference why set to wontfix.