PureStorage-OpenConnect / powershell-toolkit

The Pure Storage PowerShell Toolkit provides a number of different cmdlets ranging from core Windows Server, WMI, WSMAN, & .NET assemblies. The intention of the toolkit is to provide a library for customers and the Pure Storage field to use in troubleshooting, FlashArray reporting & other useful scenarios.
Apache License 2.0
22 stars 6 forks source link

Should the cmdlets for FlashArray authentication have the -Credentials parameter? Or global $Creds variable? #48

Open mikenelson-io opened 3 years ago

mikenelson-io commented 3 years ago

This one is up for discussion. I removed the -Credentials parameter from the cmdlets that execute a login to the FA (except for the one cmdlet that needs two sets of credentials). Instead, I added a global $Creds variable that can be defined for use with all the cmdlets in a single PoSH session. Should those cmdlets have that param? Or is a global a better option? Or is both the answer?