No error handling when an FA REST 'API Token' or Array 'endpoint' is incorrect

PureStorage-OpenConnect / pure-fa-openmetrics-exporter

Pure Storage OpenMetrics exporter for FlashArray

Apache License 2.0

18 stars 26 forks source link

No error handling when an FA REST 'API Token' or Array 'endpoint' is incorrect #12

Closed chrroberts-pure closed 1 year ago

chrroberts-pure commented 1 year ago

Currently when an incorrect API Token or endpoint is given to the exporter it will return HTTP 200 and provide the go metrics, but provide no purefa metrics.

We should implement some handling to provide an error when the API Token is incorrect and/or the endpoint is not reachable.

genegr commented 1 year ago

Agreed. Will amend the code for that. And thanks for spotting the issue!

genegr commented 1 year ago

Fixed in v1.0.2 for this exporter and on v1.0.1 for the FB exporter.