search

PureStorage-OpenConnect / pure-fa-openmetrics-exporter

Pure Storage OpenMetrics exporter for FlashArray
Apache License 2.0
20 stars 27 forks source link

Hostname correction #9

Closed chrroberts-pure closed 1 year ago

chrroberts-pure commented 1 year ago

I think the use of 'host' is better than 'name' for these metrics as 'name' is too generic and is harder to parse without the context of the metric name. It makes it more difficult for reserved tag correlation (eg. host, env, service)

We also need to figure out this for array metrics as well, should it use 'host' or 'array_name' in its dimensions?

@genegr Let's have a conversation before merging this one.

genegr commented 1 year ago

Agree with the proposed change. In general my idea is to keep as much as possible a 1:1 mapping between the attributes of objects returned by the API and the related metric labels.

chrroberts-pure commented 1 year ago

I also agree with that, but I think this is a notable exception for reserved tags.

Go ahead and merge this. Thanks!