PureSwift / Bluetooth

Pure Swift Bluetooth library
http://pureswift.github.io/Bluetooth/
MIT License
176 stars 25 forks source link

#3 Implement HCI LE commands #20

Closed colemancda closed 6 years ago

colemancda commented 6 years ago

Issue

Fixes #3.

What does this PR Do?

Adds missing HCI LE commands.

Where should the reviewer start?

LowEnergyCommandParameter.swift

Sweet giphy showing how you feel about this PR

Giphy

colemancda commented 6 years ago

Result of Integration 1

Duration: 3 minutes and 10 seconds Result: All 21 tests passed, but please fix 9 warnings. Test Coverage: 60%

colemancda commented 6 years ago

Result of Integration 1

Duration: 3 minutes and 10 seconds Result: All 21 tests passed, but please fix 9 warnings. Test Coverage: 60%

codecov[bot] commented 6 years ago

Codecov Report

Merging #20 into master will decrease coverage by 0.82%. The diff coverage is 25.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage    59.5%   58.68%   -0.83%     
==========================================
  Files          47       47              
  Lines        6715     6753      +38     
  Branches      462      461       -1     
==========================================
- Hits         3996     3963      -33     
- Misses       2693     2764      +71     
  Partials       26       26
Flag Coverage Δ
#osx 58.68% <25.6%> (-0.83%) :arrow_down:
Impacted Files Coverage Δ
Sources/GATT.swift 91.66% <ø> (ø) :arrow_up:
Sources/BitMaskOption.swift 85.18% <ø> (ø) :arrow_up:
Sources/Range.swift 100% <ø> (ø) :arrow_up:
Sources/LowEnergyAdvertising.swift 0% <0%> (ø) :arrow_up:
Sources/LowEnergyScan.swift 0% <0%> (ø) :arrow_up:
Sources/LowEnergyWhiteList.swift 0% <0%> (ø) :arrow_up:
Sources/LowEnergyConnection.swift 0% <0%> (ø) :arrow_up:
Sources/HCIGeneralEventParameter.swift 55.76% <0%> (ø) :arrow_up:
Sources/LowEnergyChannelMap.swift 0% <0%> (ø) :arrow_up:
Sources/LowEnergyCommandParameter.swift 2.4% <0%> (-0.34%) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba3cc7e...7da7838. Read the comment docs.

colemancda commented 6 years ago

Result of Integration 1

Duration: 3 minutes and 10 seconds Result: All 21 tests passed, but please fix 9 warnings. Test Coverage: 60%

colemancda commented 6 years ago

Result of Integration 2

Duration: 2 minutes and 43 seconds Result: All 21 tests passed, but please fix 9 warnings. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 2

Duration: 2 minutes and 43 seconds Result: All 21 tests passed, but please fix 9 warnings. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 2

Duration: 2 minutes and 43 seconds Result: All 21 tests passed, but please fix 9 warnings. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 3

Duration: 2 minutes and 54 seconds Result: All 21 tests passed, but please fix 9 warnings. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 3

Duration: 2 minutes and 54 seconds Result: All 21 tests passed, but please fix 9 warnings. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 3

Duration: 2 minutes and 54 seconds Result: All 21 tests passed, but please fix 9 warnings. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 4

Duration: 2 minutes and 17 seconds Result: All 21 tests passed, but please fix 8 warnings. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 4

Duration: 2 minutes and 17 seconds Result: All 21 tests passed, but please fix 8 warnings. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 5

Duration: 2 minutes and 22 seconds Result: All 21 tests passed, but please fix 1 warning. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 5

Duration: 2 minutes and 22 seconds Result: All 21 tests passed, but please fix 1 warning. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 6

Duration: 4 minutes and 43 seconds Result: All 21 tests passed, but please fix 1 warning. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 7

Duration: 2 minutes and 37 seconds Result: All 21 tests passed, but please fix 1 warning. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 7

Duration: 2 minutes and 37 seconds Result: All 21 tests passed, but please fix 1 warning. Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 8

Duration: 2 minutes and 58 seconds Result: Build failed 1 test out of 21

colemancda commented 6 years ago

Result of Integration 9

Duration: 1 second Result: -1 error, failing state: checkout-error

colemancda commented 6 years ago

Result of Integration 9

Duration: 1 second Result: -1 error, failing state: checkout-error

colemancda commented 6 years ago

Result of Integration 9

Duration: 1 second Result: -1 error, failing state: checkout-error

colemancda commented 6 years ago

Result of Integration 9

Duration: 1 second Result: -1 error, failing state: checkout-error

colemancda commented 6 years ago

Result of Integration 9

Duration: 1 second Result: -1 error, failing state: checkout-error

colemancda commented 6 years ago

Result of Integration 1

Duration: 3 minutes and 15 seconds Result: Perfect build! All 21 tests passed. :+1: Test Coverage: 59%

colemancda commented 6 years ago

Result of Integration 1

Duration: 3 minutes and 15 seconds Result: Perfect build! All 21 tests passed. :+1: Test Coverage: 59%

colemancda commented 6 years ago

@jmarkstar I removed all warnings.