search

PureWeen / ShanedlerSamples

MIT License
76 stars 13 forks source link

[Keyboard] Auto-scroll does not work on Editor (iOS) #14

Open Moro890 opened 1 year ago

Moro890 commented 1 year ago

Hello @PureWeen,

I noticed that when using the auto-scroll on Editor, the line where the "Done" button is on the keyboard, convers a part of the Editor. This happens on iOS.

Thank you!

PureWeen commented 1 year ago

@tj-devel709

FYI: This work is also part of our current .NET8 previews so you can test there without using this code

tj-devel709 commented 1 year ago

Hi @Moro890, I was not able to reproduce this issue. I'll attach a short demo of what I am seeing on my side. Would you be able to provide me a code sample with some screenshots / screen-recordings as well as let me know what type of device you are testing with? It's possible that maybe in some scenarios it is acting funny!

https://github.com/PureWeen/ShanedlerSamples/assets/50846373/e277ca0c-5323-49a4-a543-6bcdefa3c2bb

developer9969 commented 1 year ago

Hi there
Just tested both iOS and android using an editor and in iOS the editor is fully covered!! .net 7 with this nuget. KeyboardOverlap

MauiKeyboard.zip

Any suggestions?

I could not test in iOS .net 8 because I use windows host and hot restart is broken

@tj-devel709 do you have the code for your demo , may be I am doing something wrong here..

tj-devel709 commented 1 year ago

@developer9969 I was able to reproduce your issue! Totally valid and I'll take a deeper look to see what is going on! Thanks!

developer9969 commented 1 year ago

@tj-devel709 thanks for replying.. It would make such a difference as we have many pages following that pattern including our chat pages and a fix there would be fantastic..

thanks again for looking into it

tj-devel709 commented 1 year ago

It appears that when I use a .NET 7 project and use the workaround, I get the weird scrolling behavior with the Shell. From the scrolling code, it appears that the correct offset is provided but there is something funky going on with the scrolling. When I set the MainPage to a ContentPage or to a NavigationPage, I do not get the weird scrolling behavior. This also works in our main branch in Maui in Shell, ContentPage, and NavigationPage.

developer9969 commented 1 year ago

@tj-devel709 @PureWeen Hi wondering if you had the time to look at that issue with keyboard covering the editor in iOS?

Any workaround - handler suggestions? many thanks

RakitinIbis commented 1 year ago

It appears that when I use a .NET 7 project and use the workaround, I get the weird scrolling behavior with the Shell. From the scrolling code, it appears that the correct offset is provided but there is something funky going on with the scrolling. When I set the MainPage to a ContentPage or to a NavigationPage, I do not get the weird scrolling behavior. This also works in our main branch in Maui in Shell, ContentPage, and NavigationPage.

For me in content page it also doesn't work. Lib version (1.4.9) Visual Studio Community 2022 for Mac Version 17.6.1 (build 452) Apple Developer Tools Xcode: 14.3.1 21815 Build: 14E300c Xamarin.iOS Version: 16.4.0.6 Visual Studio Community Hash: 97731c92c Branch: xcode14.3 Build date: 2023-04-11 22:38:36-0400

maui-maccatalyst 7.0.92/7.0.100 SDK 7.0.300 maui-ios 7.0.92/7.0.100 SDK 7.0.300 maui-android 7.0.92/7.0.100 SDK 7.0.300 maccatalyst 16.4.7089/7.0.100 SDK 7.0.300

tj-devel709 commented 1 year ago

Hi @Moro890, sorry, things have been pretty busy and this flew under my radar! Could you post a video/screenshot of what this looks like when you use a NavigationPage on iOS .NET7 so I can compare? I also wonder if you see this behavior in all instances of when you use an editor or if you would still see this behavior when using a basic editor without border and margins/padding?

tj-devel709 commented 1 year ago

I'll also try to inspect more on this one when I get the chance!

davibittencourtome commented 1 year ago

Hello, I also have the same problem, and I've already tested with Editor and Entry, the keyboard overlaps the two controls.

The problem only occurs on iPhone 11 or higher.

I tested on .NET 7.0 with PureWeen.Maui.FixesAndWorkarounds and .NET 8.0 and identified that in .Net 8 rc1 the problem does not occur.

.NET 7.0 - Simulator - iPhone 11:

image

.NET 8.0 RC1 - Simulator - iPhone 11:

image

@PureWeen, is there any chance you can bring the solution present in .net 8 rc1 to the Maui.Fixes?

I'm having layout issues with .net 8 and don't want to use it yet.

developer9969 commented 1 year ago

We cannot publish our app in net 7 bcse of this issue . A workaround here would be fantastic. Net 8 has broken so many things elsewhere that we cannot use it . @PureWeen @tj-devel709 any workaround??

davibittencourtome commented 1 year ago

It was working in .NET 8 RC1, I tested it in .NET 8 RC 2 and the problem occurs again... how sad