Puresharper / Puresharp

Puresharp is a Framework that provides the essential APIs (AOP, IOC, etc...) to productively build high quality (.NET 4.5.2+ & .NET Core 2.1+) applications through reliability, scalability and performance without no compromise
MIT License
143 stars 17 forks source link

Support .NET Core SDK Projects #9

Closed Trojaner closed 5 years ago

Trojaner commented 5 years ago

Currently the project does not support .NET Core projects (even if targeting net472).

The reason for this is the wrong location to the IPuresharp.exe. With .NET Core SDK templates, the "packages" folder inside solution root is not used anymore.

For me it is located at C:\Users\USERNAME\.nuget\packages\ipuresharp\4.2.1 instead.

Puresharper commented 5 years ago

Hi, not sure even if I fix the nuget path to run IPuresharp.exe, dotnetcore will work fine. I have to try limitations of mono.cecil to support dotnet core.

Trojaner commented 5 years ago

Problem is not that it does not support .NET Core runtime, problem is that it does not support .NET Core Project SDK templates, which still can target full .NET Framework like v4.7.2

Puresharper commented 5 years ago

Ok, I fixed it in IPuresharp.4.2.5 by prior legacy path resolution ($(Solution)\packages\IPuresharp.x.x.x) but fallback to %USERPROFILE%.nuget\packages\IPuresharp\x.x.x when not found.