search

Puresyn / KeyMaster

Key Master addon for WoW
Other
6 stars 5 forks source link

BUG #75

Open vj234013 opened 1 month ago

vj234013 commented 1 month ago

Interface/AddOns/KeyMaster/KeyMaster.lua:18: attempt to index global 'KeyMasterLocals' (a nil value) Count: 1

Call Stack: [1] [string "@Interface/AddOns/KeyMaster/KeyMaster.lua"]:18: in main chunk

vj234013 commented 1 month ago

.../AddOns/KeyMaster/Core/Localization/Localization.lua:78: attempt to index global 'KeyMasterLocals' (a nil value) Count: 1

Call Stack: [1] [string "@Interface/AddOns/KeyMaster/Core/Localization/Localization.lua"]:78: in main chunk

Puresyn commented 1 month ago

What is the language of the client? If it is Traditional Chinese, we've had other reports as well. If not, please let us know.

vj234013 commented 1 month ago

My language is Simplified Chinese

vj234013 commented 1 month ago

This plug-in has no problem since version 1.3.4. It has problems since version 1.3.5.

Puresyn commented 1 month ago

Here is what changed. Do you see any problems/issues? https://github.com/Puresyn/KeyMaster/commit/07b0eda16038b72ae1dba3d6179723c08889ecef

vj234013 commented 1 month ago

Sorry, I don't know how to program. I replaced version 1.3.4 with the zhCN.lua file from version 1.3.6 and it works fine.Replacing the two issues in 1.3.6 with the file in 1.3.4 will still result in an error. So I guess it's not the file you asked me about that had a problem (My English is not good. The translation software used Please forgive me)

Puresyn commented 1 month ago

Sorry, I don't know how to program. I replaced version 1.3.4 with the zhCN.lua file from version 1.3.6 and it works fine.Replacing the two issues in 1.3.6 with the file in 1.3.4 will still result in an error. So I guess it's not the file you asked me about that had a problem (My English is not good. The translation software used Please forgive me)

Thanks, we will look into it.

Puresyn commented 1 month ago

I've located the problem.

KeyMaster/Core/Localization/Languages.xml Line 12 should not be commented out.

Incorrect: <!-- <Script file='Core\Localization\Localization.zhCN.lua'/> -->

Correct: <Script file='Core\Localization\Localization.zhCN.lua'/>

It was an oversight on my behalf since we lost our CN translator. Apologies. It will be fixed in the next patch.

vj234013 commented 1 month ago

Thank you very much.

vj234013 commented 1 month ago

1.3.4 image

vj234013 commented 1 month ago

1.3.6 image

Puresyn commented 1 month ago

1.3.6 image

this is correct

vj234013 commented 1 month ago

Has the explanation of affixes been removed here?

Puresyn commented 1 month ago

Has the explanation of affixes been removed here?

Moved to tooltips - Hover over affix icon in header.

vj234013 commented 1 month ago

Ok, I got it. Thanks again. Wishing the plugin continued improvement