Broken Redis checks due to a password requirement

Purple-Devs / health_check

Simple health check of Rails app for use with uptime checking sites like newrelic and pingdom

MIT License

476 stars 125 forks source link

Broken Redis checks due to a password requirement #117

Closed pyromaniac closed 2 years ago

pyromaniac commented 2 years ago

Hey everyone. First of all, thanks for the gem!

There was a breaking change introduced: https://github.com/ianheggie/health_check/commit/0eb4e1b19bafe4eae0f8ea8d0c06df75719a0126

Now we have to set config.redis_password = nil explicitly in configs. Would be actually nice to check if ENV['REDIS_PASSWORD'] is empty and in this case assign nil automatically for backwards compatibility. WDYT?

pyromaniac commented 2 years ago

Oh, right found #108 now