Purple-Devs / health_check

Simple health check of Rails app for use with uptime checking sites like newrelic and pingdom
MIT License
476 stars 125 forks source link

Use environment variable for configuring Redis password #120

Closed simonsanchez closed 2 years ago

simonsanchez commented 2 years ago

The existing documentation states

# When redis url/password is non-standard
config.redis_url = 'redis_url' # default ENV['REDIS_URL']
# Only included if set, as url can optionally include passwords as well
config.redis_password = 'redis_password' # default ENV['REDIS_PASSWORD']

Currently config.redis_password is hard-coded to the value some-password and can cause checks to fail (for instance in CI).

Workaround until this change is accepted and merged

config.redis_password = nil
simonsanchez commented 2 years ago

I didn't realize this is a duplicate of #108