search

Purple-Devs / health_check

Simple health check of Rails app for use with uptime checking sites like newrelic and pingdom
MIT License
476 stars 125 forks source link

Is Rails 7 supported? #123

Open evolve2k opened 2 years ago

evolve2k commented 2 years ago

Readme references Rails 5 and 6 and earlier. Is Rails 7 suppprted?

jmarchello commented 1 year ago

For others that may pass by here. I'm not a maintainer or anything, but have found one incompatibility with Rails 7.

One of the 'standard' check, emailconf, only runs the email check if your app's delivery method or smtp_settings are set to something besides the default. This is expected behavior. Where the incompatibility occurs is that HeathCheck keeps a hard-coded hash of what the 'expected' default settings are and compares this against your smtp_settings to know whether or not to run this check. These hard-coded default settings do not match Rails 7's default settings, and so the check will always run.

For our app, what this resulted in is that the check is run in production, looking for an smtp server at localhost:25, which does not exists. This results in a 500 response from /health_check.

jmarchello commented 1 year ago

@evolve2k We will be working towards full, tested Rails 7 support soon. It is one of our highest priorities moving forward. That said, it may take time to get various tests in place and lay some groundwork so we can stay up to date while still supporting older versions.