search

Purple-Devs / health_check

Simple health check of Rails app for use with uptime checking sites like newrelic and pingdom
MIT License
476 stars 125 forks source link

Support `redis-client` gem #131

Open y-yagi opened 1 year ago

y-yagi commented 1 year ago

Since 7.0, Sidekiq uses redis-client by default. https://github.com/sidekiq/sidekiq/commit/0b3e4c2724b2440e6fff7ed56407e82947919a64

This patch allows to users use health_check without adding redis gem with Sidekiq >= 7.0.

Fixes #128.

jmarchello commented 1 year ago

Thank you for your contribution! We'll get this reviewed and tested as soon as we can

y-yagi commented 1 year ago

@jmarchello Sorry to ping, but what do you think about this and #134?

jmarchello commented 1 year ago

This code looks good. I'm actively working on getting our tests running again and once that's done I'll be able to test and merge this change