search

Purple-Devs / health_check

Simple health check of Rails app for use with uptime checking sites like newrelic and pingdom
MIT License
476 stars 125 forks source link

include_error_in_response_body configuration removed in v3.0.0 ? #83

Closed brentsnook closed 3 years ago

brentsnook commented 5 years ago

This appears to have been removed from this version although it is back again in current master: https://github.com/ianheggie/health_check/blob/0b799ead604f900ed50685e9b2d469cd2befba5b/lib/health_check.rb#L76

This initializer breaks because the method is missing:

HealthCheck.setup do |config|
  config.include_error_in_response_body = false
end
iamonkara commented 5 years ago

Seems like there is no healthy test coverage for health_check :-1:

adamrparsons commented 4 years ago

This is still broken in the latest gem, over a year later.

shlima commented 4 years ago

@brentsnook @iamonkara @adamrparsons you can check an alternative

ianheggie commented 3 years ago

Fixed in master, and am releasing a new release after I finish testing the PRs I have merged

ianheggie commented 3 years ago

Fixed in version 3.1.0 released just now